couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juuso Väänänen (JIRA) <>
Subject [jira] Updated: (COUCHDB-687) Add md5 hash to _attachments properties for documents
Date Wed, 22 Dec 2010 13:07:04 GMT


Juuso Väänänen updated COUCHDB-687:

    Attachment: couchdb-md5-in-attachment-COUCHDB-687-v2.patch

Thanks for comments, here is patch with some cleanups and improvements done.

Major changes:
- Simple javascript tests added, etap tests contain testing also to some extent.
- Md5 is calculated from attachement data when base64 is used to upload data.
- md5 is omitted from json output when value is undefined.
- Try to keep line length on 80 chars.

- Upgrade code not fully tested (no tests included), but revised to git master.

Some questions regarding functionality:
- Should md5 be calculated when gzipped attachement is uploaded without identity md5?

> Add md5 hash to _attachments properties for documents
> -----------------------------------------------------
>                 Key: COUCHDB-687
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>         Environment: CouchDB
>            Reporter: mikeal
>            Assignee: Filipe Manana
>         Attachments: couchdb-md5-in-attachment-COUCHDB-687-v2.patch, couchdb-md5-in-attachment-COUCHDB-687.patch,
> The current attachment information looks like this:
> GET /dbname/docid
> "_attachments": {
>       "jquery-1.4.1.min.js": {
>           "content_type": "text/javascript"
>           "revpos": 138
>           "length": 70844
>           "stub": true
>       }
> }
> If a client wanted to sync local files as attachments with a document it would not currently
be able to do so without keeping a local store of the revpos. If this information included
an md5 hash of the attachment clients could compare it against a hash of the local file to
see if they match.
> -Mikeal

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message