couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Randall Leeds (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COUCHDB-992) replicator doesn't respect .ini settings for http sources
Date Tue, 21 Dec 2010 08:05:00 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Randall Leeds updated COUCHDB-992:
----------------------------------

    Attachment: 0001-respect-replicator-config-settings-COUCHDB-992.patch

Here's the patch.

couch_rep_reader no longer sets these settings when init is called, leaving it to the http_db
record to hold the correct defaults.

I changed the #http_db record to use the defaults that had been forced by couch_rep_reader
before. I thought this was safest. Since each replication between two hosts will open as many
as 100 requests at a time any change which lowered the default value of (sessions x pipeline_size)
could cause user's replications to experience a regression of surprising back-off or even
failure.

Each replication reader registers on config changes too, so it should be possible to change
how many sessions continuous or long-running replications are using without restarting them.

Thankfully, I think most of this goes away with the new replicator, but since that's not default
yet I propose this for backport to 1.0.2 and 1.1.

Unfortunately, I actually have a situation where a pre-release xulrunner-devel on my system
is preventing CouchDB from compiling. I'll have to open a separate ticket for that, but please
forgive me if this patch contains some tiny syntax error. I wanted to file it before I forgot
(again).

> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
>                 Key: COUCHDB-992
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-992
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 1.0.1
>            Reporter: Randall Leeds
>             Fix For: 1.0.2, 1.1
>
>         Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides
them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message