Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 67818 invoked from network); 30 Nov 2010 15:45:20 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Nov 2010 15:45:20 -0000 Received: (qmail 28728 invoked by uid 500); 30 Nov 2010 15:45:19 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 28581 invoked by uid 500); 30 Nov 2010 15:45:19 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 28573 invoked by uid 99); 30 Nov 2010 15:45:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Nov 2010 15:45:19 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of fdmanana@gmail.com designates 74.125.83.52 as permitted sender) Received: from [74.125.83.52] (HELO mail-gw0-f52.google.com) (74.125.83.52) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Nov 2010 15:45:12 +0000 Received: by gwj18 with SMTP id 18so387869gwj.11 for ; Tue, 30 Nov 2010 07:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=FjkHyOZzxvC2k3EeMFu2pwe7GEAUmjfUQ9Yb9oeqq+I=; b=qVrkoKK1XWYsb+u2dAgvf9LeLvJVY06W+opx9EvWEzh90R1TFZesO5BxUR0okqG1JG clKQQAfs8wSAkJ/H86JTv1lyVb53grp4S4RsSsjy6X+MKfsmF427wdqMJesqLARGJ99T TMFg/BzXc+mnP8apccBLC6HtX42BekRNgcmaw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=ilVaPKLi4Fd77ZA9qMobL1zD/7xFUgypQwyu/8TqYajFILndCp/OlpmUcqkkfjtGF7 9tfhIK/pafHE8/9vQFj4r0t6jXBXBKPBWdKiKeElLEC3N8qDMqZbgK5mnyMxYZayajUk LOtoMJSL1WHsDXEVhk0bu+Xjgg3wRaUCinRJA= MIME-Version: 1.0 Received: by 10.223.74.141 with SMTP id u13mr1945343faj.62.1291131891186; Tue, 30 Nov 2010 07:44:51 -0800 (PST) Sender: fdmanana@gmail.com Received: by 10.223.2.11 with HTTP; Tue, 30 Nov 2010 07:44:51 -0800 (PST) In-Reply-To: References: Date: Tue, 30 Nov 2010 15:44:51 +0000 X-Google-Sender-Auth: wO08LmlRCe68WgLT6SsTsfutRYw Message-ID: Subject: Re: use view functions to emit changes From: Filipe David Manana To: dev@couchdb.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > > Here is an updated patch. It now use a filter sandbox instead of > patching the function and it fixes whitespaces. Why a separate function to init the filter_sandbox? It can be done at the end of the existing init_sandbox() function (perhaps renaming it to init_sandboxes). I would rename Filter.filter_view to Filter.view_filter or to Filter.map_filter (doing the same in src/couchdb/couch_query_servers.erl for naming consistency). 4) is still there (the debugging ?LOG_INFO line). Also, this patch should only contain the changes necessary to implement the new feature. While all the whitespace and indentation fixes (to comply with the wiki rules) are a welcome plus, they should come in a separate patch imo. good work regards, --=20 Filipe David Manana, fdmanana@gmail.com, fdmanana@apache.org "Reasonable men adapt themselves to the world. =C2=A0Unreasonable men adapt the world to themselves. =C2=A0That's why all progress depends on unreasonable men."