Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 61976 invoked from network); 16 Nov 2010 19:03:52 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Nov 2010 19:03:52 -0000 Received: (qmail 204 invoked by uid 500); 16 Nov 2010 19:04:23 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 170 invoked by uid 500); 16 Nov 2010 19:04:23 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 162 invoked by uid 99); 16 Nov 2010 19:04:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Nov 2010 19:04:22 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bchesneau@gmail.com designates 209.85.212.180 as permitted sender) Received: from [209.85.212.180] (HELO mail-px0-f180.google.com) (209.85.212.180) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Nov 2010 19:04:15 +0000 Received: by pxi13 with SMTP id 13so27884pxi.11 for ; Tue, 16 Nov 2010 11:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=3y0kw7Z6DWD2il0qto42Kdji0KfflcpG52myOCWKGCo=; b=IybGsQU/K6DM0HIyc1X5fsG2xUK37qkJQQxSd0/bLL8nXAaYmFIalUEYcyAm88k3QT dmSVH69nXZTF3aOmnVgO5LvsttUq2tIicEx3xUj86cboKTl+RJn3H7HM1Gij+gI7ZcOn 6B1O7O1GT2PLbZYMUl0pZthMY39zE28751Afk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=ao29/y8XG1BbdSDdd6Q7se7eAzjCtrLGEWCPLjBE4VGFn67xJQ2MlDA0Bj9I2BKwd7 wlYhZuwbD2RtNn/Cye/445IN3Oeon9r7BWg8GFFGNRckc/wST3B4jegJFhek+FZXITgS lKsVFnHfYJYtgIPaDczFqN4fX/UAR6+poE8WU= MIME-Version: 1.0 Received: by 10.231.10.137 with SMTP id p9mr4832141ibp.186.1289934232636; Tue, 16 Nov 2010 11:03:52 -0800 (PST) Received: by 10.231.8.146 with HTTP; Tue, 16 Nov 2010 11:03:52 -0800 (PST) In-Reply-To: <2943BBE6-DA0C-4FE8-916A-6880BA921B68@apache.org> References: <20101116170122.7722823889DD@eris.apache.org> <2943BBE6-DA0C-4FE8-916A-6880BA921B68@apache.org> Date: Tue, 16 Nov 2010 20:03:52 +0100 Message-ID: Subject: Re: svn commit: r1035694 - /couchdb/trunk/src/couchdb/couch_changes.erl From: Benoit Chesneau To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Nov 16, 2010 at 7:59 PM, Jan Lehnardt wrote: > that is: if(_doc_ids === undefined || typeof(_doc_ids) !== "list") > > // actually typeof(_doc_ids) === "undefined" for the first clause > > If you can point me out to me that a defined list could also be > undefined, I'm happy to accept your wording :) > I don't say that . I said that doc_ids could be undefined or not a list which is wrong. eg. someone didn't fill the body, gave an object, a string, etc. I'm speaking about the current state of the doc_ids variable not about what we expect it should be. That's the difference between 2 sentences.