Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 58430 invoked from network); 16 Nov 2010 18:55:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Nov 2010 18:55:49 -0000 Received: (qmail 86284 invoked by uid 500); 16 Nov 2010 18:56:21 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 86238 invoked by uid 500); 16 Nov 2010 18:56:21 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 86228 invoked by uid 99); 16 Nov 2010 18:56:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Nov 2010 18:56:20 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bchesneau@gmail.com designates 209.85.214.180 as permitted sender) Received: from [209.85.214.180] (HELO mail-iw0-f180.google.com) (209.85.214.180) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Nov 2010 18:56:13 +0000 Received: by iwn37 with SMTP id 37so1175234iwn.11 for ; Tue, 16 Nov 2010 10:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=fKmNPNvVdeL8ir1RAfPat3QLobGIn/HQE6xSvUrj4IY=; b=mav8953byYTtMR3xqsZAFaVxiiuwuYUgXmWO5+5W9g+L/RTK9PCNo3vOY2RWQtCSG8 J+77vEvGBQqqbS/BcFbqQ56xzlXGR01BKoar6A5G3GR+k8DWvm7H0nZkYt12jZp8CmS8 BeuF+5IDPORyzKQfsc2CkC9LxueUUspsJBvp8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=orwylt2SgiBfd2B4p7khWeDiWQ0KOoBZCUahDAnij0RGcTAxqVtecTvIpNT/EWxpG0 grfX21oo2rBzM9JIaqzVq3RKEJ5BR1a1T5MFLtyke+9QgSQbk3XnTsFbP9DK8jlxyQgM 5yiH2RkClbMMN8AErZipawI1fw+Fab1Ovj/dg= MIME-Version: 1.0 Received: by 10.231.39.133 with SMTP id g5mr5961190ibe.161.1289933751302; Tue, 16 Nov 2010 10:55:51 -0800 (PST) Received: by 10.231.8.146 with HTTP; Tue, 16 Nov 2010 10:55:51 -0800 (PST) In-Reply-To: References: <20101116170122.7722823889DD@eris.apache.org> Date: Tue, 16 Nov 2010 19:55:51 +0100 Message-ID: Subject: Re: svn commit: r1035694 - /couchdb/trunk/src/couchdb/couch_changes.erl From: Benoit Chesneau To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Nov 16, 2010 at 7:45 PM, Jan Lehnardt wrote: > > On 16 Nov 2010, at 19:36, Benoit Chesneau wrote: > >> On Tue, Nov 16, 2010 at 7:28 PM, Benoit Chesneau wrote: >>> On Tue, Nov 16, 2010 at 7:19 PM, Filipe David Manana >>> wrote: >> s a list, you are less descriptive. >>>>> >>>> >>>> If it's not defined than it's definitely not a list. Does it make sense? >>> I didn't say that your sentence didn't have sense. But I meant to be >>> more descriptive. Afterall that's the reason you want to use === >>> rather than == in js. >>> >> >> To be clear , I prefer to give all reasons why this error happened >> rather than using a mind shortcut and while I'm on it maybe it could >> be better if i just give the right reason? The only reason I don't >> actually is because I wanted to use less code > > I don't get it. > > You said _doc_ids === undefined || typeof(_doc_ids) != List. no i said if typeof(doc_ids) === "list"