couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benoit Chesneau <bchesn...@gmail.com>
Subject Re: svn commit: r1035694 - /couchdb/trunk/src/couchdb/couch_changes.erl
Date Tue, 16 Nov 2010 19:14:10 GMT
On Tue, Nov 16, 2010 at 8:03 PM, Benoit Chesneau <bchesneau@gmail.com> wrote:
> On Tue, Nov 16, 2010 at 7:59 PM, Jan Lehnardt <jan@apache.org> wrote:
>
>> that is: if(_doc_ids === undefined || typeof(_doc_ids) !== "list")
>>
>> // actually typeof(_doc_ids) === "undefined" for the first clause
>>
>> If you can point me out to me that a defined list could also be
>> undefined, I'm happy to accept your wording :)
>>
> I don't say that . I said that doc_ids could be undefined or not a
> list which is wrong. eg. someone didn't fill the body, gave an object,
> a string, etc. I'm speaking about the current state of the doc_ids
> variable not about what we expect it should be. That's the difference
> between 2 sentences.
>

but anyway. I'm not against the change, just wanted to state that is
wasn't what I meant. and I really prefer to be descriptive.

Mime
View raw message