Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com
 designates 209.85.214.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=u7OSMxcr/2ZZtCll0MINhKf2nHR4YNJO2PRuv9a1bCrK7oXE0JmZ9HV73dSun8bYmy
         yKMXs6yB5JtIsjgg3IAAVON8M9Hgzf9mEXlwQujj4rYxw2rgYyBniqWBDRKzdMSlZ9Tp
         ivByW2xgEof6gVYUrRF8/d29nYj479tTCUHFk=
MIME-Version: 1.0
In-Reply-To: <AANLkTimcJD+n8RGqQ9fPO2ULJsu_WuEiHo_zr_ynL24q@mail.gmail.com>
References: <AANLkTikf+tQN9sNBnsfWZcOUOG=1Vm7X83eGYT8f+135@mail.gmail.com>
 <AANLkTikQ_x5WnrdHnP5C9G81cPy8daGDZrz5KvyE2W0D@mail.gmail.com>
 <AANLkTim1UiYxJb9Qtx0RemqMN1N56iePAyBnVFfb5wTC@mail.gmail.com>
 <AANLkTikemAu=V9LC++Fj6jxDrgmS87Z+hvz_MZNdEVpf@mail.gmail.com>
 <AANLkTini9zHQEkt84XNfFCSpXBTEu8gpPLygmAauo_wj@mail.gmail.com>
 <AANLkTimcJD+n8RGqQ9fPO2ULJsu_WuEiHo_zr_ynL24q@mail.gmail.com>
From: Paul Davis <paul.joseph.davis@gmail.com>
Date: Thu, 14 Oct 2010 19:21:11 -0400
Message-ID: <AANLkTinAxCSzUbTkiq=2DbCPgaa=8xc9KV3_XTn=ELbj@mail.gmail.com>
Subject: Re: filter changes for some docids
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 14, 2010 at 7:05 PM, Filipe David Manana
<fdmanana@apache.org> wrote:
> On Fri, Oct 15, 2010 at 12:04 AM, Filipe David Manana
> <fdmanana@apache.org> wrote:
>> Now that we have this, I think I should change the replicator to
>> profit of this _changes feature and allow for continuous replication
>> by doc IDs.
>> Anyone against?
>
> Not only would allow for the continuous replication but also would
> imply removing ugly code from the replicator
> My +1
>

+1

>>
>>
>> On Wed, Oct 13, 2010 at 10:10 PM, Benoit Chesneau <bchesneau@gmail.com> =
wrote:
>>> On Wed, Oct 13, 2010 at 6:21 PM, Paul Davis <paul.joseph.davis@gmail.co=
m> wrote:
>>>> On Wed, Oct 13, 2010 at 12:05 PM, Filipe David Manana
>>>> <fdmanana@apache.org> wrote:
>>>>> For a matter of consistency with the replicator, I would name the
>>>>> field as "doc_ids" instead of "docids".
>>>>>
>>>>> All the rest seems fine to me.
>>>>>
>>>>> On Wed, Oct 13, 2010 at 4:24 PM, Benoit Chesneau <bchesneau@gmail.com=
> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> For a project I have to know each time a design doc change and for n=
ow
>>>>>> I have to create a filter function for each databases created to do
>>>>>> that. I think getting changes on specific docids is a common behavio=
r
>>>>>> (see replication for example) so I thought to add the possibility to
>>>>>> filters changes on docids if a list of documents is passed in the
>>>>>> request.
>>>>>>
>>>>>> ex:
>>>>>>
>>>>>> POST /db/_changes
>>>>>> {"docids": ["id1", ..]}
>>>>>>
>>>>>>
>>>>>> Here is the patch that allows that feature :
>>>>>> http://github.com/benoitc/couchdb/commit/fd7829b6b3093ab324a2b5c4966=
00cc6335480b8
>>>>>>
>>>>>> What do you think about it ?
>>>>>>
>>>>>> - benoit
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Filipe David Manana,
>>>>> fdmanana@gmail.com, fdmanana@apache.org
>>>>>
>>>>> "Reasonable men adapt themselves to the world.
>>>>> =A0Unreasonable men adapt the world to themselves.
>>>>> =A0That's why all progress depends on unreasonable men."
>>>>>
>>>>
>>>> Looks fine to me. And I'd agree with filipe about using doc_ids for co=
nsistency.
>>>>
>>> commited with changes from docids to doc_ids + fixed safari test.
>>> Thank for the review :)
>>>
>>> - benoit
>>>
>>
>>
>>
>> --
>> Filipe David Manana,
>> fdmanana@gmail.com, fdmanana@apache.org
>>
>> "Reasonable men adapt themselves to the world.
>> =A0Unreasonable men adapt the world to themselves.
>> =A0That's why all progress depends on unreasonable men."
>>
>
>
>
> --
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
>
> "Reasonable men adapt themselves to the world.
> =A0Unreasonable men adapt the world to themselves.
> =A0That's why all progress depends on unreasonable men."
>