Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 20653 invoked from network); 13 Oct 2010 16:23:12 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Oct 2010 16:23:12 -0000 Received: (qmail 65057 invoked by uid 500); 13 Oct 2010 16:23:11 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 65024 invoked by uid 500); 13 Oct 2010 16:23:11 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 65016 invoked by uid 99); 13 Oct 2010 16:23:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 16:23:11 +0000 X-ASF-Spam-Status: No, hits=2.5 required=10.0 tests=FREEMAIL_FROM,FREEMAIL_REPLY,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of paul.joseph.davis@gmail.com designates 209.85.213.52 as permitted sender) Received: from [209.85.213.52] (HELO mail-yw0-f52.google.com) (209.85.213.52) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Oct 2010 16:23:05 +0000 Received: by ywk9 with SMTP id 9so2681263ywk.11 for ; Wed, 13 Oct 2010 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=6fIuqsv3ut7LuGpC4yozrJwlUKFw6cwSMg/KDVNVlpc=; b=DPW8LEF3AR+v8PgG6Lo9j91mqHHynlZ0t/Qab9RB0Nh9eHxhGiZlHvTZw84D+zFvBB 55NXPrimva8/sLqmDLiQsJh+dHGq/VAFtLiw7ssGokin/2xk9kI6rDfqtZSFq5EIzjdS vxcAWwW8pZGBrage4X2OdcxH5C7VEwrfz8I5w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=S7O5+Scrnrp3+rGzCm96JZ41dH9tCQ6kGlAqL66FCo+gAD8owot2kECKfmUX9WfziE OrKDwsjd8nBvxB8ILB9dwEOZ371aDu8bHRYxynfqsIJJh5J592m0/pzM3+/CSY+d37pB yDFqD45SF53Er9i5BVTZwdh1velCd5OLJ0Ljc= Received: by 10.42.191.210 with SMTP id dn18mr4178624icb.288.1286986963804; Wed, 13 Oct 2010 09:22:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.30.194 with HTTP; Wed, 13 Oct 2010 09:21:59 -0700 (PDT) In-Reply-To: References: From: Paul Davis Date: Wed, 13 Oct 2010 12:21:59 -0400 Message-ID: Subject: Re: filter changes for some docids To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Wed, Oct 13, 2010 at 12:05 PM, Filipe David Manana wrote: > For a matter of consistency with the replicator, I would name the > field as "doc_ids" instead of "docids". > > All the rest seems fine to me. > > On Wed, Oct 13, 2010 at 4:24 PM, Benoit Chesneau wr= ote: >> Hi all, >> >> For a project I have to know each time a design doc change and for now >> I have to create a filter function for each databases created to do >> that. I think getting changes on specific docids is a common behavior >> (see replication for example) so I thought to add the possibility to >> filters changes on docids if a list of documents is passed in the >> request. >> >> ex: >> >> POST /db/_changes >> {"docids": ["id1", ..]} >> >> >> Here is the patch that allows that feature : >> http://github.com/benoitc/couchdb/commit/fd7829b6b3093ab324a2b5c496600cc= 6335480b8 >> >> What do you think about it ? >> >> - benoit >> > > > > -- > Filipe David Manana, > fdmanana@gmail.com, fdmanana@apache.org > > "Reasonable men adapt themselves to the world. > =A0Unreasonable men adapt the world to themselves. > =A0That's why all progress depends on unreasonable men." > Looks fine to me. And I'd agree with filipe about using doc_ids for consist= ency.