From dev-return-12531-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Thu Oct 14 23:04:53 2010 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 18460 invoked from network); 14 Oct 2010 23:04:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Oct 2010 23:04:53 -0000 Received: (qmail 72782 invoked by uid 500); 14 Oct 2010 23:04:52 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 72685 invoked by uid 500); 14 Oct 2010 23:04:52 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 72672 invoked by uid 99); 14 Oct 2010 23:04:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Oct 2010 23:04:52 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of fdmanana@gmail.com designates 209.85.160.180 as permitted sender) Received: from [209.85.160.180] (HELO mail-gy0-f180.google.com) (209.85.160.180) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Oct 2010 23:04:46 +0000 Received: by gyg4 with SMTP id 4so101719gyg.11 for ; Thu, 14 Oct 2010 16:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=EoPTuKbglwcYzmqfzRyNT9BRWZtVD5JjWAfSprYjZNo=; b=gNUz8UrYyoWnTPZ1cjF5ynM7lIGKZhvry6axl0szVLL0Cc4cUZ71gFfdLLppFBWUQG cfV1HBarkrgAjOXPeYk4y0RV7tmr6L3FBoV8/9RbJFkbPmes80x/bvromm/Vj473IEc9 mfWM9Im23Mw1Uf9f9WvMexgX3UBCGAk0nDeRo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=X76KjTvkW2TX0VnEfAj677DcpT2ZD8cd5dfh9u2ZEDBXuiVu7X2x3ZsIVoe/JkZlCL L6mi5TZKV3t8bKlXruBEDGdLM5jGxW5Z7kxFsTYj3O5VOIVghMBarU5iOGZi0ZH0XPev fnsKtGkx7PPY2DrQt+kyaSAd9hvZFqVBW/gug= MIME-Version: 1.0 Received: by 10.100.93.17 with SMTP id q17mr6506692anb.16.1287097464606; Thu, 14 Oct 2010 16:04:24 -0700 (PDT) Sender: fdmanana@gmail.com Received: by 10.101.66.19 with HTTP; Thu, 14 Oct 2010 16:04:24 -0700 (PDT) In-Reply-To: References: Date: Fri, 15 Oct 2010 00:04:24 +0100 X-Google-Sender-Auth: Z0jAwdfXDri2ZCMKa2KbkU1gljQ Message-ID: Subject: Re: filter changes for some docids From: Filipe David Manana To: dev@couchdb.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Now that we have this, I think I should change the replicator to profit of this _changes feature and allow for continuous replication by doc IDs. Anyone against? On Wed, Oct 13, 2010 at 10:10 PM, Benoit Chesneau wro= te: > On Wed, Oct 13, 2010 at 6:21 PM, Paul Davis = wrote: >> On Wed, Oct 13, 2010 at 12:05 PM, Filipe David Manana >> wrote: >>> For a matter of consistency with the replicator, I would name the >>> field as "doc_ids" instead of "docids". >>> >>> All the rest seems fine to me. >>> >>> On Wed, Oct 13, 2010 at 4:24 PM, Benoit Chesneau = wrote: >>>> Hi all, >>>> >>>> For a project I have to know each time a design doc change and for now >>>> I have to create a filter function for each databases created to do >>>> that. I think getting changes on specific docids is a common behavior >>>> (see replication for example) so I thought to add the possibility to >>>> filters changes on docids if a list of documents is passed in the >>>> request. >>>> >>>> ex: >>>> >>>> POST /db/_changes >>>> {"docids": ["id1", ..]} >>>> >>>> >>>> Here is the patch that allows that feature : >>>> http://github.com/benoitc/couchdb/commit/fd7829b6b3093ab324a2b5c496600= cc6335480b8 >>>> >>>> What do you think about it ? >>>> >>>> - benoit >>>> >>> >>> >>> >>> -- >>> Filipe David Manana, >>> fdmanana@gmail.com, fdmanana@apache.org >>> >>> "Reasonable men adapt themselves to the world. >>> =C2=A0Unreasonable men adapt the world to themselves. >>> =C2=A0That's why all progress depends on unreasonable men." >>> >> >> Looks fine to me. And I'd agree with filipe about using doc_ids for cons= istency. >> > commited with changes from docids to doc_ids + fixed safari test. > Thank for the review :) > > - benoit > --=20 Filipe David Manana, fdmanana@gmail.com, fdmanana@apache.org "Reasonable men adapt themselves to the world. =C2=A0Unreasonable men adapt the world to themselves. =C2=A0That's why all progress depends on unreasonable men."