couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filipe David Manana <fdman...@apache.org>
Subject Re: filter changes for some docids
Date Thu, 14 Oct 2010 23:05:55 GMT
On Fri, Oct 15, 2010 at 12:04 AM, Filipe David Manana
<fdmanana@apache.org> wrote:
> Now that we have this, I think I should change the replicator to
> profit of this _changes feature and allow for continuous replication
> by doc IDs.
> Anyone against?

Not only would allow for the continuous replication but also would
imply removing ugly code from the replicator
My +1

>
>
> On Wed, Oct 13, 2010 at 10:10 PM, Benoit Chesneau <bchesneau@gmail.com> wrote:
>> On Wed, Oct 13, 2010 at 6:21 PM, Paul Davis <paul.joseph.davis@gmail.com> wrote:
>>> On Wed, Oct 13, 2010 at 12:05 PM, Filipe David Manana
>>> <fdmanana@apache.org> wrote:
>>>> For a matter of consistency with the replicator, I would name the
>>>> field as "doc_ids" instead of "docids".
>>>>
>>>> All the rest seems fine to me.
>>>>
>>>> On Wed, Oct 13, 2010 at 4:24 PM, Benoit Chesneau <bchesneau@gmail.com>
wrote:
>>>>> Hi all,
>>>>>
>>>>> For a project I have to know each time a design doc change and for now
>>>>> I have to create a filter function for each databases created to do
>>>>> that. I think getting changes on specific docids is a common behavior
>>>>> (see replication for example) so I thought to add the possibility to
>>>>> filters changes on docids if a list of documents is passed in the
>>>>> request.
>>>>>
>>>>> ex:
>>>>>
>>>>> POST /db/_changes
>>>>> {"docids": ["id1", ..]}
>>>>>
>>>>>
>>>>> Here is the patch that allows that feature :
>>>>> http://github.com/benoitc/couchdb/commit/fd7829b6b3093ab324a2b5c496600cc6335480b8
>>>>>
>>>>> What do you think about it ?
>>>>>
>>>>> - benoit
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Filipe David Manana,
>>>> fdmanana@gmail.com, fdmanana@apache.org
>>>>
>>>> "Reasonable men adapt themselves to the world.
>>>>  Unreasonable men adapt the world to themselves.
>>>>  That's why all progress depends on unreasonable men."
>>>>
>>>
>>> Looks fine to me. And I'd agree with filipe about using doc_ids for consistency.
>>>
>> commited with changes from docids to doc_ids + fixed safari test.
>> Thank for the review :)
>>
>> - benoit
>>
>
>
>
> --
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
>
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."
>



-- 
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

Mime
View raw message