couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benoit Chesneau <bchesn...@gmail.com>
Subject Re: filter changes for some docids
Date Wed, 13 Oct 2010 21:10:41 GMT
On Wed, Oct 13, 2010 at 6:21 PM, Paul Davis <paul.joseph.davis@gmail.com> wrote:
> On Wed, Oct 13, 2010 at 12:05 PM, Filipe David Manana
> <fdmanana@apache.org> wrote:
>> For a matter of consistency with the replicator, I would name the
>> field as "doc_ids" instead of "docids".
>>
>> All the rest seems fine to me.
>>
>> On Wed, Oct 13, 2010 at 4:24 PM, Benoit Chesneau <bchesneau@gmail.com> wrote:
>>> Hi all,
>>>
>>> For a project I have to know each time a design doc change and for now
>>> I have to create a filter function for each databases created to do
>>> that. I think getting changes on specific docids is a common behavior
>>> (see replication for example) so I thought to add the possibility to
>>> filters changes on docids if a list of documents is passed in the
>>> request.
>>>
>>> ex:
>>>
>>> POST /db/_changes
>>> {"docids": ["id1", ..]}
>>>
>>>
>>> Here is the patch that allows that feature :
>>> http://github.com/benoitc/couchdb/commit/fd7829b6b3093ab324a2b5c496600cc6335480b8
>>>
>>> What do you think about it ?
>>>
>>> - benoit
>>>
>>
>>
>>
>> --
>> Filipe David Manana,
>> fdmanana@gmail.com, fdmanana@apache.org
>>
>> "Reasonable men adapt themselves to the world.
>>  Unreasonable men adapt the world to themselves.
>>  That's why all progress depends on unreasonable men."
>>
>
> Looks fine to me. And I'd agree with filipe about using doc_ids for consistency.
>
commited with changes from docids to doc_ids + fixed safari test.
Thank for the review :)

- benoit

Mime
View raw message