couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (COUCHDB-542) Fix for COUCHDB-288 makes JS_MaybeGC not called
Date Fri, 08 Oct 2010 23:47:31 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Joseph Davis resolved COUCHDB-542.
---------------------------------------

    Resolution: Not A Problem

Using the callbacks for GC'ing isn't necessary as we ensure that JS_MaybeGC is called frequently
due to the Erlang timeouts on commands.

> Fix for COUCHDB-288 makes JS_MaybeGC not called
> -----------------------------------------------
>
>                 Key: COUCHDB-542
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-542
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>            Reporter: Mike Hommey
>
> The fix for COUCHDB-288 only basically replaces JS_SetBranchCallback with JS_SetOperationCallback,
which is not enough for the callback to be triggered. The problem is that basically, the operation
callback API has now nothing to do with the previous branch callback API, and is not called
at each branch call at the JS level. Actually, it is not called at all, except if JS_TriggerOperationCallback
is used. Typically, this needs to be done either from a signal handler or a watchdog thread,
in which case the test inside the callback is pretty pointless.
> See http://groups.google.com/group/mozilla.dev.tech.js-engine/browse_thread/thread/a4d1fe147761aacb/e61d2592faf4ef72?lnk=gst&q=js_setoperationcallback#e61d2592faf4ef72
for reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message