couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-920) BTree: modify_node() and complete_root() functions do not make a new btree record
Date Thu, 14 Oct 2010 17:34:36 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921038#action_12921038
] 

Paul Joseph Davis commented on COUCHDB-920:
-------------------------------------------

Andrey,

That patch looks correct to me. At this point I'm not sure I'd commit it just to clean up
that relatively minor point though. I've been meaning to find time to go through and clean
up the btree code considerably but haven't gotten around to it. Being such a core section
of code I'd rather make fewer large changes rather than many small changes. If for no other
reason than it makes bisecting easier. :D

If a couple other committers sign off on it then I'd feel fine committing it. I did fix the
typo you noted though.

Also, keep digging on that code as the more people that understand some of these core parts
the better.

> BTree: modify_node() and complete_root() functions do not make a new btree record
> ---------------------------------------------------------------------------------
>
>                 Key: COUCHDB-920
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-920
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.0.1
>            Reporter: Andrey Somov
>            Priority: Minor
>         Attachments: btree_issue920.patch
>
>
> BTree: modify_node() and complete_root() functions do not make a new btree record. But
nevertheless they return a btree as if it is different. The patch simplifies the code and
makes it clear that only query_modify() function makes a new btree record.
> tests are OK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message