Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com
 designates 209.85.210.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=jA6+KV6/FxIumpDlNt0FzFfrJPZ+5jJ6O8ZEEm2jIuY7KRkPJm8M1LE19OO034E1PK
         Gwj21j4vppU/wTcpp4Ct5P47wdHaATpMd0sPwdI07v1Hd6G89GiISYKHVo4g4fK93qWR
         AAdqD/hc/y1imwuxiaa9b6jaJA+0vq+OkW+Rw=
MIME-Version: 1.0
In-Reply-To: <AANLkTinKadHwNX8R0eMMo5ALG+-y_GgunBnxtc1MM-LW@mail.gmail.com>
References: <AANLkTimAaaXAP0FEt=At2KbVuyemm1-74JLdQe3PeDp=@mail.gmail.com>
 <E1CBDA6C-5BD2-4934-A593-BE5509852E91@apache.org>
 <AANLkTinKadHwNX8R0eMMo5ALG+-y_GgunBnxtc1MM-LW@mail.gmail.com>
From: Paul Davis <paul.joseph.davis@gmail.com>
Date: Mon, 27 Sep 2010 14:11:02 -0400
Message-ID: <AANLkTi=_eK1KVp0J9VmbUokqNFr7=xQWsThZyVvU+0=-@mail.gmail.com>
Subject: Re: adding new macro to couch_db.hrl
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 27, 2010 at 2:06 PM, Filipe David Manana
<fdmanana@apache.org> wrote:
> On Mon, Sep 27, 2010 at 7:04 PM, Adam Kocoloski <kocolosk@apache.org> wro=
te:
>> I don't like "get" because it clashes with the auto-imported erlang:get =
(for the process dictionary).
>>
>> Any reason to prefer a macro over an -import statement?
>
> Just to avoid doing the import everywhere and I still consider
> get_value too long :P
>
>>
>> Adam
>>
>> On Sep 27, 2010, at 1:47 PM, Filipe David Manana wrote:
>>
>>> Hi,
>>>
>>> I'm getting tired of typing couch_util:get_value(......). It also
>>> consumes too much horizontal space. It's probably the most used
>>> function from couch_util.
>>> I'm thinking of adding a new macro in couch_db.hrl, like:
>>>
>>> -define(value(Key, List), couch_util:get_value(Key, List)).
>>>
>>> -define(value(Key, List, Default), couch_util:get_value(Key, List, Defa=
ult)).
>>>
>>> Or maybe naming the macro just "get".
>>>
>>> Anyone against it?
>>>
>>>
>>> cheers
>>>
>>> --
>>> Filipe David Manana,
>>> fdmanana@gmail.com, fdmanana@apache.org
>>>
>>> "Reasonable men adapt themselves to the world.
>>> =A0Unreasonable men adapt the world to themselves.
>>> =A0That's why all progress depends on unreasonable men."
>>
>>
>
>
>
> --
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
>
> "Reasonable men adapt themselves to the world.
> =A0Unreasonable men adapt the world to themselves.
> =A0That's why all progress depends on unreasonable men."
>

I'd have to agree with Filipe that I'd probably rather see a macro
than an import. For some reason or another imports tend to annoy me
because its a layer of indirection between what's being called.
Granted, in some of those cases its probably more of a sign that we
need to break some of the various files into sub modules and what not.
More at 10.