couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lehnardt <...@apache.org>
Subject Re: 160-* etap test failure from time to time
Date Wed, 18 Aug 2010 19:29:50 GMT

On 18 Aug 2010, at 20:17, Robert Dionne wrote:

> The vhosts refactoring made this issue go away. The underlying problem still exists in
couch_config. It's a race condition

The refactoring also added a whole lot of things that are separate from this issue.

I recon the test could start couch_http and only issue requests once it is fully up*.

*I haven't looked at any code here, just handwaving.

Cheers
Jan
-- 


> 
> 
> 
> 
> On Aug 18, 2010, at 2:01 PM, Jan Lehnardt wrote:
> 
>> 
>> On 16 Aug 2010, at 13:00, Benoit Chesneau wrote:
>> 
>>> So I've found why 160- test fails from time to time:
>>> 
>>> Vhosts are loaded at startup when creating the mochiweb loop. So it
>>> only get depending how fast is your machine 1 result and maybe 0 for
>>> really fast machines since the ini isn't defined.
>> 
>> this sounds like a race condition that should be fixed in the test.
>> 
>>> Which also make it
>>> impossible to change vhosts on the fly apparently (via POST on
>>> /_config).
>> 
>> I do that all the time and it works. I'm not sure how you're drawing
>> your conclusion here :)
>> 
>> Cheers
>> Jan
>> -- 
>> 
>> 
>>> To solve that and allows us to change/add vhosts on the fly I would
>>> like to change the code and put all vhosts handling in a gen_server
>>> keeping states etc so it could be possible to changes vhosts in memory
>>> depending on ini change. Also it would make vhost handling pluggable
>>> so someone could imagine to create them via doc posted in a db.
>>> 
>>> What do you think ?
>>> 
>>> - benoit
>> 
> 


Mime
View raw message