couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <>
Subject [jira] Commented: (COUCHDB-862) replicator.js fails to run in standalone js tests
Date Thu, 19 Aug 2010 14:00:16 GMT


Filipe Manana commented on COUCHDB-862:

Bob, thanks for the patch.

The use of those jQuery functions is actually my fault.

I looked at the patch and have the following remarks:

1)  don't do === "[object Array]"
     do instead   repResult.history instanceof Array

2) the replacement for $.inArray  would be array.indexOf(element)  (return value -1 means
not found, else found)
    therefore avoiding those for loops to search for the element


> replicator.js fails to run in standalone js tests
> -------------------------------------------------
>                 Key: COUCHDB-862
>                 URL:
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Test Suite
>         Environment: OS X
>            Reporter: Bob Dionne
>            Priority: Trivial
>         Attachments: replicator.js.patch
> replicator.js uses some jQuery functions such as jQuery.each and inArray, which causes
it to fail when tests are run outside the browser

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message