couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Bonser <mister...@gmail.com>
Subject Re: 1.0 Vote
Date Thu, 24 Jun 2010 16:47:34 GMT
On Thu, Jun 24, 2010 at 10:38 AM, J Chris Anderson <jchris@gmail.com> wrote:
>
> On Jun 23, 2010, at 5:13 PM, Paul Bonser wrote:
>
>> It'd probably be good to get this in 1.0:
>> https://issues.apache.org/jira/browse/COUCHDB-748
>>
>> Not a big bug, but not a big patch either, and it affects anyone with
>> "<", ">", or "&" in their docids or view keys.
>>
>
> I got all set to commit this, except for the fact that I can't reproduce the issue. I
don't have this bug on trunk, so either it got fixed already or I'm not reproducing it correctly.

So, looking at it, I guess somebody already fixed the issue with the
keys and IDs on the first line. But the issue with the IDs on the
second line is still there.

>
> Can anyone reproduce the issue, and give me a hint how.

Create a doc with an id of "&amp;<foo>", then go to the "All
Documents" page. On the first line you'll see "&amp;<foo>", but on the
second line all you'll see is "&"

I've updated the patch once again to only have the necessary changes,
namely: moving the nested escape function to $.futon.escape so it can
be used externally, and using it to escape the ID on the second line
of each line in the document list.

>
> Thanks,
> Chris
>
>> On Wed, Jun 23, 2010 at 5:47 PM, Damien Katz <damien@apache.org> wrote:
>>> I think we are really close to being ready for 1.0.
>>>
>>> Are there any issues/patches that need to be handled before we make a release
and vote on it?
>>>
>>> Noah, do you have any issues, and can you make the branch and release candidate?
>>>
>>> One thing I can think of is windows file support, so that compaction and deletion
work properly. There exists a fix for it from Mark Hammond, but we need a patched Erlang VM
before the fix can work. The upcoming R14B includes the VM patch, but I think we should wait
until it's actually released before we include Mark's fix.
>>>
>>> -Damien
>>
>>
>>
>> --
>> Paul Bonser
>> http://probablyprogramming.com
>
>



-- 
Paul Bonser
http://probablyprogramming.com

Mime
View raw message