couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COUCHDB-794) skip costly selective receive for delayed_commit
Date Sat, 12 Jun 2010 18:46:13 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adam Kocoloski closed COUCHDB-794.
----------------------------------

    Resolution: Fixed

Thanks Randall.  I committed a functionally equivalent patch.  The only real difference is
that instead of

catch erlang:cancel_timer(Timer)

I did

if is_reference(Timer) -> erlang:cancel_timer(Timer); true -> ok end,

I presume checking the is_reference guard is cheaper than catching the badarg from trying
to cancel a non-reference.



> skip costly selective receive for delayed_commit
> ------------------------------------------------
>
>                 Key: COUCHDB-794
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-794
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Randall Leeds
>            Assignee: Adam Kocoloski
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: delayed_commits_no_receive.patch
>
>
> There's no reason to consume outstanding delayed_commit messages when a commit does occur
since they can be ignored later if the waiting_delayed_commit flag is nil. The selective receive
could be costly if the writer queue is long.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message