couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COUCHDB-780) Don't block the updater process while compaction deletes old files
Date Sat, 12 Jun 2010 19:56:13 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adam Kocoloski updated COUCHDB-780:
-----------------------------------

    Attachment: 0001-async-file-deletions.-COUCHDB-780.patch

Hi Randall, I liked the concept, so I took it a step further.  I've attached a patch to add
a couch_file:delete/1 function which does a rename-and-spawn-delete like you wrote in couch_db_updater.
 I've changed the codebase to use this function exclusively, with the exception of couch_view:nuke_dir
which uses the error code from file:delete to ascertain that it tried to delete a directory.

What do you think?

> Don't block the updater process while compaction deletes old files
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-780
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-780
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.10.2, 0.11
>            Reporter: Randall Leeds
>             Fix For: 1.1
>
>         Attachments: 0001-async-file-deletions.-COUCHDB-780.patch, async_compact_delete.patch
>
>
> I have what I think is a simple patch I'll attach. I don't see any reason not to include
it unless rename operations can be seriously slow on some filesystems (but I expect this is
not the case).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message