couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-765) load_view contains needles module prefixed function calls
Date Tue, 18 May 2010 12:52:44 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868632#action_12868632
] 

Adam Kocoloski commented on COUCHDB-765:
----------------------------------------

Hi Volker, just to clarify, that's not strictly a cosmetic change.  A call to M:F(A) always
uses the newest version of the code in the VM, while a call to F(A) uses whatever version
is running when the call is made.  The difference is critically important for hot-code loading
in the case of a server loop function, e.g. if you do

loop(State) ->
    ...
    loop(State).

you'll never load a new version of the code, but if you do

loop(State) ->
    ...
    ?MODULE:loop(State).

you'll get the new version automatically when the loop recurses.

Of course, it doesn't make any difference in this case, as hot-code loading is not an issue
for those functions.  Thanks for the patch.

> load_view contains needles module prefixed function calls
> ---------------------------------------------------------
>
>                 Key: COUCHDB-765
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-765
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Volker Mische
>            Priority: Trivial
>             Fix For: 0.12
>
>         Attachments: load_view.patch
>
>
> It's only a cosmetic change. The load_view/4 in couch_httpd_view.erl contains some calls
to functions within the module but prefixes the calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message