Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of jchris@gmail.com designates
 74.125.83.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=content-type:mime-version:subject:from:in-reply-to:date
         :content-transfer-encoding:message-id:references:to:x-mailer;
        b=Kdt2MuRd0nY4jdWtYbEccFj+0+Jvdpd/5wICCg3AruIp0vFPEe+lr3yVJnvuMiNpBk
         h8LRGaPtoa+uQhlZOUWihRBxaRL+VFVql3GaoCLiEGbKnKaof0gXiDyXwtK+E9M5XKU3
         k4ASL0vCDP4/4jRKm1+A22ZeeB35PnHLCPTFE=
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1077)
Subject: Re: Virtual Hosts
From: J Chris Anderson <jchris@gmail.com>
In-Reply-To: <9D2F6BE1-DD90-4702-9196-ED6FBE8B6246@apache.org>
Date: Thu, 18 Feb 2010 18:30:42 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <1A230BF8-1C82-4C4E-8B21-9145FB8AABB9@gmail.com>
References: <9D2F6BE1-DD90-4702-9196-ED6FBE8B6246@apache.org>
To: dev@couchdb.apache.org


On Feb 18, 2010, at 6:23 PM, Jan Lehnardt wrote:

> Hi dev@,
>=20
> I added virtual host handling to CouchDB. I have a Github branch for =
you to check out:
>=20
>  http://github.com/janl/couchdb/commits/vhosts
>=20
> Alternatively, here's a full diff including etap tests:=20
>=20
>  http://www.friendpaste.com/6B5dQU1fb27boOvxhm2nhf
>=20
> =46rom local.ini:
>=20
> ; To enable Virtual Hosts in CouchDB, add a vhost =3D path directive. =
All requests to
> ; the Virual Host will be redirected to the path. In the example below =
all requests
> ; to http://example.com/ are redirected to /database.
> ; If you run CouchDB on a specific port, include the port number in =
the vhost:
> ; example.com:5984 =3D /database
>=20
> [vhosts]
> ;example.com =3D /database/
>=20
> In combination with Benoit's rewriter, this allows you to create =
virtual hosts with=20
> really pretty URLs.=20
>=20
> The CouchDB default behaviour isn't changed. CouchDB simply inspects a
> request's `Host:` header and maps it against any defined virtual =
hosts. If a
> match is found, CouchDB will make an internal redirect much like the =
rewriter.
>=20
> I did a stupid A/B test with Apache Bench and couldn't see any =
performance
> degradation. Feel free to prove me wrong :)
>=20
> I'd like to commit this to trunk and also backport to 0.11. What do =
you think?
>=20

This code looks really good and simple. Way to go.

+1 on including it in 0.11 as there's really nothing to this (especially =
for people who don't enable it).

> Thanks for you feedback.
>=20
> Cheers
> Jan
> --
>=20