Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 19696 invoked from network); 17 Feb 2010 07:04:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Feb 2010 07:04:53 -0000 Received: (qmail 67645 invoked by uid 500); 17 Feb 2010 07:04:52 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 67515 invoked by uid 500); 17 Feb 2010 07:04:51 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 67505 invoked by uid 99); 17 Feb 2010 07:04:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 07:04:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 07:04:49 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0E523234C4A8 for ; Tue, 16 Feb 2010 23:04:28 -0800 (PST) Message-ID: <1665174052.329131266390268057.JavaMail.jira@brutus.apache.org> Date: Wed, 17 Feb 2010 07:04:28 +0000 (UTC) From: "Filipe Manana (JIRA)" To: dev@couchdb.apache.org Subject: [jira] Commented: (COUCHDB-640) Detect when a view is not valid for a database In-Reply-To: <759091533.84151265410348046.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834669#action_12834669 ] Filipe Manana commented on COUCHDB-640: --------------------------------------- Funny, there seems to be a time issue with Jira. My last comment/upload is dated as before the previous one from yesterday. > Detect when a view is not valid for a database > ---------------------------------------------- > > Key: COUCHDB-640 > URL: https://issues.apache.org/jira/browse/COUCHDB-640 > Project: CouchDB > Issue Type: Bug > Components: JavaScript View Server > Affects Versions: 0.11 > Reporter: Paul Joseph Davis > Attachments: couchdb-640-trunk-2.patch, couchdb-640-trunk-3.patch, couchdb-640-trunk.patch > > > It was mentioned on IRC that if someone restores a database without restoring a view then there's nothing that detects if the view is still valid. Ie, it may reflect an update_seq that the restoration lost. > In the check for kicking off a view update we should check if there is an incompatibility between what's been calculated in the view vs what the db update sequence is at. The current logic will just ignore and return the invalid view data (because of how stale=ok works which is good). > Should be an easy bug to fix if anyone's interested. The code should be pretty contained to couch_view.erl and couch_view_group.erl -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.