From dev-return-8871-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Fri Feb 26 12:28:49 2010 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 38833 invoked from network); 26 Feb 2010 12:28:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Feb 2010 12:28:49 -0000 Received: (qmail 49128 invoked by uid 500); 26 Feb 2010 12:28:48 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 49076 invoked by uid 500); 26 Feb 2010 12:28:48 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 49064 invoked by uid 99); 26 Feb 2010 12:28:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2010 12:28:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2010 12:28:48 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E99FB29A0016 for ; Fri, 26 Feb 2010 04:28:27 -0800 (PST) Message-ID: <388704161.553571267187307955.JavaMail.jira@brutus.apache.org> Date: Fri, 26 Feb 2010 12:28:27 +0000 (UTC) From: "Filipe Manana (JIRA)" To: dev@couchdb.apache.org Subject: [jira] Updated: (COUCHDB-549) include_docs=true doesn't honour conflicts=true In-Reply-To: <517680442.1257109679385.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filipe Manana updated COUCHDB-549: ---------------------------------- Attachment: couchdb-549-trunk.patch Following patch fixes it. JS test included. cheers > include_docs=true doesn't honour conflicts=true > ----------------------------------------------- > > Key: COUCHDB-549 > URL: https://issues.apache.org/jira/browse/COUCHDB-549 > Project: CouchDB > Issue Type: Improvement > Components: HTTP Interface > Affects Versions: 0.11 > Reporter: Brian Candler > Priority: Minor > Attachments: couchdb-549-trunk.patch > > > When you read a view and use the option 'include_docs=true' to get the source document in each result row, the option 'conflicts=true' is not honoured. You do not see a _conflicts member in the document, even if it is in a conflicting state. > This feature request could be expanded in a couple of directions: > 1. Make include_docs=true honour *all* options which a straightforward GET would honour - e.g. revs, revs_info, open_revs. Maybe this would be straightforward if they shared the same code path and options processing. > 2. It has been suggested that 'conflicts=true' could be the default anyway. That is, whenever you retrieve a document, you get a _conflicts member if it is in a conflicting state, without having to ask for it. This would be unlikely to break things, but would make it less likely that conflicts would go unnoticed, and it would simplify the API a little. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.