couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-64) Enable selective replication
Date Fri, 08 Jan 2010 15:32:56 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798042#action_12798042
] 

Adam Kocoloski commented on COUCHDB-64:
---------------------------------------

Thanks for the patch.  Using _changes is certainly the way to accomplish this.  I have a couple
of comments:

1) The patch only addresses filtered replication from a remote source.  Ultimately we want
it to work for local sources too.  Note that couch_rep_changes_feed:init/1 has two clauses,
one for remote sources and one for local sources.

2) Can you write tests?  Either JS or etap is fine.

3) The patch doesn't follow our coding conventions, specifically 4-space indents and a soft
limit of 80 characters per line.

Best, Adam

> Enable selective replication
> ----------------------------
>
>                 Key: COUCHDB-64
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-64
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>         Environment: All
>            Reporter: Jan Lehnardt
>            Priority: Minor
>             Fix For: 0.11
>
>         Attachments: replication_filter.patch
>
>
> Make it possible to filter the set of documents that is to be replicated. Also allow
replication to omit attachment-data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message