couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Anderson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-589) Simplify Query Server interface and Design Handlers
Date Thu, 03 Dec 2009 01:21:20 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785111#action_12785111
] 

Chris Anderson commented on COUCHDB-589:
----------------------------------------

Adam,

Thanks for finding COUCHDB-404, I think it's important people see that I'm removing the legacy
/db/_view API in this patch.

It was easier to delete that code than maintain it as I was working on the refactor, so I
deleted it.

I don't like maintaining API surface area that doesn't add functionality, and now is a good
time to fix this. COUCHDB-404 showed that we can support the legacy view API if we need to.
But that's a lot of code-weight for backwards compatibility with our alpha APIs.

There are lots of other little fixes in here as well, I think this patch fixes the issue discussed
recently on user@ about _show responses and missing documents [1], as well as doing a general
clean-up in the interest of making the query server code easier to understand, as well as
prepping for my function-hashing optimization.

[1] http://mail-archives.apache.org/mod_mbox/couchdb-user/200912.mbox/%3c1259663713.7371.37.camel@zelda.buyways.nl%3e

If there are lots of people still hitting /db/_view/ on 0.10.x of course I'm open to discussion,
but I think this API isn't needed in 0.11.

Chris

> Simplify Query Server interface and Design Handlers
> ---------------------------------------------------
>
>                 Key: COUCHDB-589
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-589
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: JavaScript View Server
>            Reporter: Chris Anderson
>            Assignee: Chris Anderson
>         Attachments: design_handlers.patch
>
>
> This patch refactors list, show, update, filter, and view handling to have a unified
interface for loading the design document and functions from it. It is a step on the path
to removing a lot of function src passing overhead from the view server protocol.
> The patch also removes some old part of the API while improving other parts of the API.
> The big changes:
> Load the design document before handing it to the design document handlers. This removes
a lot of duplicated code.
> Remove /db/_view handler. I think it's in our interest to remove the last bits of the
old-style API before 0.11.
> I also clean up some rough edges in the API.
> I plan to commit this patch soon, but want to give people an opportunity to look it over.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message