Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Message-ID: <1431966504.1258474541830.JavaMail.jira@brutus>
Date: Tue, 17 Nov 2009 16:15:41 +0000 (UTC)
From: "Adam Kocoloski (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Subject: [jira] Commented: (COUCHDB-570) CouchDB code improvements
In-Reply-To: <1989925062.1258473579914.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778963#action_12778963 ] 

Adam Kocoloski commented on COUCHDB-570:
----------------------------------------

Thanks Kostis, in general the diff looks just fine.  Personally, I prefer not to bind too many variables in the argument list of a function and instead reserve that space for pattern matching, but in the simple cases that you/tidier chose to do this it seems fine.  I can take a closer look and apply this in the next day or two if no one beats me to it.

Thanks for the note about the partial_find/4 function, too.  That's very fresh code from Damien, perhaps he has a chance to double-check it.

> CouchDB code improvements
> -------------------------
>
>                 Key: COUCHDB-570
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-570
>             Project: CouchDB
>          Issue Type: Question
>            Reporter: Kostis Sagonas
>            Priority: Minor
>         Attachments: DIFFS
>
>
> Finally I've found the time today to sign up to jira (username: kostis).
> I have a whole bunch of changes to the CouchDB code which were produced by 'tidier' (Jan Lehnard knows about this).
> I am wondering what's the best way of contributing them? Create an issue and attach a patch/diff file? (I've done so)
> Or maybe you prefer some other way?
> Also, I've noticed that function couch_httpd:find_partial/4 returns either 'not_found' or {partial, N, K} but the place where this result is used (couch_httpd:673 or so) checks for matching against 'not_found' or {partial, Skip}.  Somebody needs to fix that.
> Best,
> Kostis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.