couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-558) Validate Content-MD5 request headers on uploads
Date Sun, 22 Nov 2009 13:06:39 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781120#action_12781120
] 

Paul Joseph Davis commented on COUCHDB-558:
-------------------------------------------

Filipe,

Apologies for being quiet the last couple days. I was on a trip down to NYC.

The patch is definitely starting to look much better, but there are a couple things. When
using the standalone attachment API like you are in the tests, the data isn't supposed to
be base64 encoded. The base64 encoding only applies when including attachment data directly
in the JSON documents.

I think this is getting much closer to being good to go. Can you check and see if there's
more to the diff though? I'm not seeing a definition of the check_md5 function. Once I have
that I'll apply and check it out locally, then it should be pretty quick to get in.

Thanks for all your work on this ticket.

> Validate Content-MD5 request headers on uploads
> -----------------------------------------------
>
>                 Key: COUCHDB-558
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-558
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core, HTTP Interface
>            Reporter: Adam Kocoloski
>             Fix For: 0.11
>
>         Attachments: jira-couchdb-558-4th-try.patch, jira-couchdb-558-5th-try.patch,
jira-couchdb-558-6th-try-trunk.patch, jira-couchdb-558-7th-try-trunk.patch, jira-couchdb-558-for-trunk-2nd-try.patch,
jira-couchdb-558-for-trunk-3rd-try.patch, jira-couchdb-558-for-trunk.patch, run.tpl.patch
>
>
> We could detect in-flight data corruption if a client sends a Content-MD5 header along
with the data and Couch validates the MD5 on arrival.
> RFC1864 - The Content-MD5 Header Field
> http://www.faqs.org/rfcs/rfc1864.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message