couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Bronson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-547) add "compact view" button to futon
Date Fri, 30 Oct 2009 05:54:59 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771815#action_12771815
] 

Joshua Bronson commented on COUCHDB-547:
----------------------------------------

> I didn't notice a difference because the grayed out style made the entire icon disappear.


Yikes, that's no good. Are you able to see the fourth icon from the top when you view http://github.com/jab/couchdb/blob/master/share/www/image/compact.png?
If not, maybe it's your monitor's brightness/contrast settings; if so, maybe your browser
was using a cached copy of that image? This would explain your not seeing the icon, as the
old version of the image was only 96 pixels high, and the new button.disabled style sets a
vertical background-position of -94px. I'll append a ?0.10.0 to the url for that background-image
in the css file to make sure this doesn't happen.


> go ahead and make those fixes and we'll get this committed.

I pushed the fixes to http://github.com/jab/couchdb. I'll have a new patched attached to this
ticket tomorrow.


> Feel free to flip a quarter on grayed vs hidden.

I'm inclined to leave it grayed out, and not just because it was extra work! (It was fun anyway:)
My theory is that graying it out actually does communicate its state better than not showing
it at all. Maybe your not seeing the icon properly screwed up that communication. And also
your eyes and mousing hand like it better when widgets stay where they are; sometimes having
them disappear violates the principle of least astonishment[1]. I can get the opinion of one
of the designers in my office tomorrow. Or maybe just give it another look once I submit the
new patch and you can see the grayed out icon, and let me know if you still prefer it hidden!

[1] http://en.wikipedia.org/wiki/Principle_of_least_astonishment :)

> add "compact view" button to futon
> ----------------------------------
>
>                 Key: COUCHDB-547
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-547
>             Project: CouchDB
>          Issue Type: New Feature
>          Components: HTTP Interface
>            Reporter: Joshua Bronson
>            Priority: Minor
>         Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7...
> compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see
http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message