Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Message-ID: <1423915095.1249408335334.JavaMail.jira@brutus>
Date: Tue, 4 Aug 2009 10:52:15 -0700 (PDT)
From: "Damien Katz (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Subject: [jira] Commented: (COUCHDB-377) allow native view servers
In-Reply-To: <9651423.1244348647364.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739063#action_12739063 ] 

Damien Katz commented on COUCHDB-377:
-------------------------------------

This patch looks good to me, though I would like to see some JS based tests using the run_on_modified_server functionality in the test suite.

> allow native view servers
> -------------------------
>
>                 Key: COUCHDB-377
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-377
>             Project: CouchDB
>          Issue Type: Improvement
>            Reporter: Mark Hammond
>         Attachments: couch_native_process.erl, erlang_test_include_docs.patch, native_query_servers.patch, native_query_servers.patch, native_query_servers2.patch, query_proc.patch
>
>
> There has been some discussion on IRC etc about how to support 'native' view servers, such as 'erlview' in a generic way.  Currently using erlview requires you to modify couch.
> I'm attaching a patch as a first attempt at supporting this.  In summary, the patch now looks up a new 'native_query_servers' config file section for a list of view_server names with a {Module, Func, Args} style string specifying the entry-point of the view server.  The code now passes an additional atom around indicating if the PID is 'native' or 'external', and map_docs takes advantage of this to avoid the json step.  This patch allows erlview to work for me, but in theory any erlang code could be used here.
> I'm very new at erlang - please let me know if I should make stylistic or other changes, or indeed if I should take a different approach completely.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.