From dev-return-5546-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Wed Aug 05 14:13:36 2009 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 38286 invoked from network); 5 Aug 2009 14:13:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Aug 2009 14:13:36 -0000 Received: (qmail 19241 invoked by uid 500); 5 Aug 2009 14:13:42 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 19146 invoked by uid 500); 5 Aug 2009 14:13:42 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 19136 invoked by uid 99); 5 Aug 2009 14:13:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2009 14:13:42 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=10.0 tests=ALL_TRUSTED,NORMAL_HTTP_TO_IP,WEIRD_PORT X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2009 14:13:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 15D71234C1ED for ; Wed, 5 Aug 2009 07:13:15 -0700 (PDT) Message-ID: <406573849.1249481595088.JavaMail.jira@brutus> Date: Wed, 5 Aug 2009 07:13:15 -0700 (PDT) From: "Adam Kocoloski (JIRA)" To: dev@couchdb.apache.org Subject: [jira] Commented: (COUCHDB-452) couch logs an [error] record if a client disconnects In-Reply-To: <2010134692.1249435934915.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739516#action_12739516 ] Adam Kocoloski commented on COUCHDB-452: ---------------------------------------- Thanks for fixing the {exit,normal} stuff, Mark. I don't have an opinion about whether to remove the explicit checks for badarg and function_clause errors. > couch logs an [error] record if a client disconnects > ---------------------------------------------------- > > Key: COUCHDB-452 > URL: https://issues.apache.org/jira/browse/COUCHDB-452 > Project: CouchDB > Issue Type: Improvement > Reporter: Mark Hammond > Attachments: dont_log_error_on_disconnect.patch > > > If a client makes a request which returns multiple rows (eg, a query) but disconnects before reading the response, couch logs: > [error] [<0.66.0>] Uncaught error in HTTP request: {exit,normal} > [info] [<0.66.0>] Stacktrace: [{mochiweb_request,send,2}, > {couch_httpd,send_chunk,2}, > {couch_httpd_view,send_json_view_row,5}, > {couch_httpd_view,'-make_view_fold_fun/6-fun-0-',12}, > {couch_view,fold_fun,4}, > {couch_btree,stream_kv_node2,7}, > {couch_btree,stream_kp_node,7}, > {couch_btree,fold,5}] > This could lead someone to conclude couch has an error which is not correct. A simple [info] record recording the premature normal exit is probably more appropriate. > FYI, the easiest way I found to repro this was to execute: > % python -c "import urllib; urllib.urlopen('http://127.0.0.1:5984/your_db/_design/your_design_doc/_view/your_view?reduce=false').close()" > which causes Python to open a connection and close it without reading anything. I'll attach a patch as suggested generally by jchris. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.