couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <>
Subject [jira] Commented: (COUCHDB-377) allow native view servers
Date Mon, 10 Aug 2009 07:02:14 GMT


Paul Joseph Davis commented on COUCHDB-377:

When Mark added the JS tests it pointed out that we weren't accounting for when ErlJSON objects
were using atoms instead of binaries. I'm going to look into the doc_to_json calls and if
possible munge all atoms (except null, true, and false) to their binary representations.

This didn't actually break anything, but in the Erlang code you'd have to figure out what
type the key was when doing porplists:get_value calls.

> allow native view servers
> -------------------------
>                 Key: COUCHDB-377
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>            Reporter: Mark Hammond
>         Attachments: couch_native_process.erl, erlang_test_include_docs.patch, native_query_servers.patch,
native_query_servers.patch, native_query_servers2.patch, native_view_js_tests.patch, query_proc.patch
> There has been some discussion on IRC etc about how to support 'native' view servers,
such as 'erlview' in a generic way.  Currently using erlview requires you to modify couch.
> I'm attaching a patch as a first attempt at supporting this.  In summary, the patch now
looks up a new 'native_query_servers' config file section for a list of view_server names
with a {Module, Func, Args} style string specifying the entry-point of the view server.  The
code now passes an additional atom around indicating if the PID is 'native' or 'external',
and map_docs takes advantage of this to avoid the json step.  This patch allows erlview to
work for me, but in theory any erlang code could be used here.
> I'm very new at erlang - please let me know if I should make stylistic or other changes,
or indeed if I should take a different approach completely.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message