couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damien Katz (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-421) add longpolling for _changes
Date Mon, 20 Jul 2009 21:22:14 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733361#action_12733361
] 

Damien Katz commented on COUCHDB-421:
-------------------------------------

Style wise this patch looks good, however you must change the indention tabs to spaces.

I recommend instead of adding the  longpolling_changes call in the code, just reuse the keep_sending_changes
call, and after the call to send_changes, add a check if  EndSeq > StartSeq and the long
poll option is on, stop,

Also I'm not sure about calling it "long_poll", but I don't have a better name myself.

> add longpolling for _changes
> ----------------------------
>
>                 Key: COUCHDB-421
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-421
>             Project: CouchDB
>          Issue Type: New Feature
>    Affects Versions: 0.10
>            Reporter: Benoit Chesneau
>         Attachments: longpoll.diff
>
>
> Implement longpolling on _changes. Instead of continuous, longpolling hold 
> request until an update is available then close it. The client will have 
> to ask a new connection. Should solve problem for XHR's  that don't have that status
changed (on ie, opera..) .
> I've put all the code in my github repo :
> http://github.com/benoitc/couchdb/tree/longpoll
> diff against trunk is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message