couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-389) [PATCH] Make offset calculation more available during btree folding
Date Mon, 06 Jul 2009 16:09:14 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727604#action_12727604
] 

Paul Joseph Davis commented on COUCHDB-389:
-------------------------------------------

For reference, this patch makes sure that an offset is calculated for all view responses.
Before if the view didn't return any rows, no offset was calculated. I plan on adding this
tonight unless someone spots an error.

> [PATCH] Make offset calculation more available during btree folding
> -------------------------------------------------------------------
>
>                 Key: COUCHDB-389
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-389
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.9
>            Reporter: Brad Anderson
>            Priority: Minor
>         Attachments: clustered_offset.patch, couchdb-389-2.svn.patch, couchdb-389-3.git.patch,
couchdb-389.svn.patch
>
>
> When CouchDB returns no values for _all_docs (or potentially any fold over the btree),
then no offset is calculated, either.  This is not a problem in non-clustered CouchDB.  However,
when you are in a clustered environment and treat each shard as its own CouchDB, then not
returning an offset when no values are found on the shard can be problematic.  The specific
case is if there is a startkey or skip specified, and there were values before (or after with
descending=true) the startkey or skip values, but there are no current values.
> Moving the Offset calculation to be available for all clauses in the return fun of couch_httpd_view:make_view_fold_fun/6
allows the user to store Offsets in the RowFunAcc and client code using this function will
work as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message