From dev-return-3366-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Mon Mar 16 02:57:59 2009 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 2221 invoked from network); 16 Mar 2009 02:57:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Mar 2009 02:57:59 -0000 Received: (qmail 70918 invoked by uid 500); 16 Mar 2009 02:57:58 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 70888 invoked by uid 500); 16 Mar 2009 02:57:58 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 70877 invoked by uid 99); 16 Mar 2009 02:57:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Mar 2009 19:57:58 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com designates 74.125.46.31 as permitted sender) Received: from [74.125.46.31] (HELO yw-out-2324.google.com) (74.125.46.31) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2009 02:57:50 +0000 Received: by yw-out-2324.google.com with SMTP id 2so598749ywt.5 for ; Sun, 15 Mar 2009 19:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=y/6EP3GgnohZyiiNADqEUvBx7ISQh+kr09KzFoq2aNY=; b=l0saiyw7tqyotE3Y2g1U9bNKM6T2MehcgM6APACv8cycIL2AL8DWEUQroWQhnjBv4C HtQih84Ins8n/RHJEoC6xistdsU/0i8g8tviBmjjtCnmn2NNTAL2IZvurQt1rLmV4SUf ZMQdGBMomJ73LVILq3qQuVxGwvf8eSkSK5OFQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=VmyURupZYDJG9NbUTEPDsQwOqbkteucn5+sEjq6Jd49qhS27xXpT6+Qgxgh8KCEZqm wM82JXKL/k9vbUfs9uEEknbR+UjDj77i7Wqk2H2wsTJ5G3ec43DlMqcAxZzTIn3DxHrR xX+ECNgs0WykDmZenAJI0Zr9bQiMQz7BW2iu8= MIME-Version: 1.0 Received: by 10.100.151.8 with SMTP id y8mr1166685and.106.1237172249334; Sun, 15 Mar 2009 19:57:29 -0700 (PDT) In-Reply-To: <748F2AED-E6F2-41B6-8744-C62DBC37587C@jasondavies.com> References: <748F2AED-E6F2-41B6-8744-C62DBC37587C@jasondavies.com> Date: Sun, 15 Mar 2009 22:57:29 -0400 Message-ID: Subject: Re: 0.9 final sprint From: Paul Davis To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Sun, Mar 15, 2009 at 8:16 PM, Jason Davies wrote= : > Hi Paul, > > On 15 Mar 2009, at 23:40, Paul Davis wrote: > >> * https://issues.apache.org:443/jira/browse/COUCHDB-183 >> No pagination in Futon for reduce views >> >> Looks like Jason Davies has got a couple patches up for this one. I >> haven't tried applying them but he's left a note saying that there's a >> todo item for blank pages at the beginning or end of the key range. >> I'd defer to Christopher Lenz on this one. > > > Yep, I would recommend at least applying the patch as it stands (assuming > cmlenz is happy with it) as it is extremely useful for anyone using reduc= e > views in Futon. > > The only remaining issue is that you can't tell if you are at the end of = the > key range as reduce views don't return "total_rows", hence it will just s= how > zero rows if you carry on clicking "Next Page" (if descending=3Dtrue is u= sed > this happens at the beginning instead of the end). =A0The fix would be to > fetch rows_per_page + 1 and check if returned_rows.length is less than th= is. > > Unless there are any objections to the above approach, I don't mind spend= ing > a bit of time tomorrow afternoon working up an updated patch so we can ge= t > this nailed. > > -- > Jason Davies > > www.jasondavies.com > > I have a sever lack of JavaScript-Fu, but looking over it I don't see anything controversial. My thoughts would be to finish out the patch for the rows+1 to get it rounded out.