From dev-return-3290-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Tue Mar 10 23:02:07 2009 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 93581 invoked from network); 10 Mar 2009 23:02:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Mar 2009 23:02:07 -0000 Received: (qmail 95269 invoked by uid 500); 10 Mar 2009 23:02:06 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 95230 invoked by uid 500); 10 Mar 2009 23:02:06 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 95219 invoked by uid 99); 10 Mar 2009 23:02:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2009 16:02:06 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.97.50.139] (HELO jan.prima.de) (83.97.50.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2009 23:01:58 +0000 Received: from [10.0.1.6] (e178217216.adsl.alicedsl.de [::ffff:85.178.217.216]) (AUTH: LOGIN jan, TLS: TLSv1/SSLv3,128bits,AES128-SHA) by jan.prima.de with esmtp; Tue, 10 Mar 2009 23:01:36 +0000 Message-Id: From: Jan Lehnardt To: dev@couchdb.apache.org In-Reply-To: <2389ED95-C566-494A-9869-EEA42C382A2F@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: rep_security merge to trunk Date: Wed, 11 Mar 2009 00:01:03 +0100 References: <2389ED95-C566-494A-9869-EEA42C382A2F@apache.org> X-Mailer: Apple Mail (2.930.3) X-Virus-Checked: Checked by ClamAV on apache.org On 10 Mar 2009, at 23:44, Damien Katz wrote: > I think the rep_security branch is looking pretty solid. I still > have work to do to merge with Adam's recent replicator changes. > > This patch breaks the file format and replication API, so > replication with earlier versions is not possible. And the "all or > nothing w/ conflict checking" transactions are gone. Which I think > is good, because people were relying on it without understanding the > rest of CouchDB doesn't support that feature. > > I'd like to go ahead and merge this to trunk. Comments, suggestions > and objections please. I have an app that could benefit of the other variant of bulk transactions that you offered in the initial proposal, namely having all writes go through, regardless if they create conflicts or not. Replication already offers this and a bulk request with the `new_edits:false` flag set will give me that behaviour, but not for documents that don't have a `_rev` member. CouchDB crashes when I send it. I believe the patch to be not too hard (adding new `_rev`s where they are missing) or I missing anything? I'm happy to come up with a patch, if there are no objections. I also don't think this would block merging the branch to trunk. Cheers Jan --