Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 17933 invoked from network); 26 Feb 2009 18:51:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Feb 2009 18:51:38 -0000 Received: (qmail 71336 invoked by uid 500); 26 Feb 2009 18:51:37 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 70975 invoked by uid 500); 26 Feb 2009 18:51:37 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 70964 invoked by uid 99); 26 Feb 2009 18:51:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2009 10:51:37 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of paul.joseph.davis@gmail.com designates 209.85.217.162 as permitted sender) Received: from [209.85.217.162] (HELO mail-gx0-f162.google.com) (209.85.217.162) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2009 18:51:29 +0000 Received: by gxk6 with SMTP id 6so1628564gxk.11 for ; Thu, 26 Feb 2009 10:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=RBalBnlHBNQD0JTi+vxbcXcuSaN9Jv8Z9/+2VazWp1g=; b=JS8XK5f7wLyW9iDnsPvaQubixpGS6RnsOs7odV0X4JhDxibkVxICRSjoHzFogYAv9h nwUvCNCHX9qyzHVantNlfA9wSFgYy/a+NRjqzkGQyKXZix0h5CrwS8xDXg/zbpy5UUHK 0I20dxTFsLY12+lcprbAyOMVfsZYuflcRCXvk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Nxda5+UChfoc+hPi2bxRlBYizlhzOAhCP1HjIvDRuQVvsqcuIQDG9eoPxkD7Ucy5wC Jw43hrhVUVHxnUVGEMvU/Vs+EXU0nUJmpCq+Y+x3PWrbwAe8D7MxUdgYWAfpCDNqqoI+ Stg9O/zgXdnrVOipgdNM4J6NXvvdHT2u4dsyo= MIME-Version: 1.0 Received: by 10.100.41.9 with SMTP id o9mr1867310ano.39.1235674268263; Thu, 26 Feb 2009 10:51:08 -0800 (PST) In-Reply-To: <883966F9-9F17-439D-B4CB-84672131FBCE@apache.org> References: <883966F9-9F17-439D-B4CB-84672131FBCE@apache.org> Date: Thu, 26 Feb 2009 13:51:08 -0500 Message-ID: Subject: Re: Stats From: Paul Davis To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org A small suggestion might be to move the registering of stat descriptions next to the code that records the stats so that adding new recordings keeps code separate. Not a major concern by any means though. HTH, Paul Davis On Thu, Feb 26, 2009 at 12:33 PM, Jan Lehnardt wrote: > Hi, > > thanks for your feedback! r748217 has some new goodies. > > On 23 Feb 2009, at 15:51, Jan Lehnardt wrote: >> >> So far we have: >> >> {couchdb, open_databases} >> {couchdb, request_time} >> >> {httpd, bulk_requests} >> {httpd, head_requests} >> {httpd, get_requests} >> {httpd, put_requests} >> {httpd, post_requests} >> {httpd, delete_requests} >> {httpd, copy_requests} >> {httpd, move_requests} >> >> {httpd, document_copies} >> {httpd, document_creates} >> {httpd, document_deletes} >> {httpd, document_moves} >> {httpd, document_reads} >> {httpd, document_updates} >> {httpd, requests} >> {httpd, temporary_view_reads} >> {httpd, view_reads} >> >> {http_status_codes, Code} (Code is one of 200, 201, 203 ... ) >> >> I'd suggest >> - to move the `document_*` keys from `httpd` to `couchdb`, > > I removed the `document_*` metrics and replaced them with > `database_reads` / `_changes` metrics. They count metrics even > if the request does not come through the HTTP API and from > a low-level perspective, document creates, updates and deletes > are really just database changes (or appends). So only reads > and writes are tracked on this level. > >> - to rename `httpd` to `http`. > > Didn't happen. > > >> Is there anything else that you think should look different? > > I added human readable descriptions to each metric. > > Anything else you'd like to see? Otherwise I'd call the API final > except for more metrics that we might add over time. > > Cheers > Jan > -- > >