couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COUCHDB-185) group=true is silently dropped in non-reduce views
Date Sun, 01 Feb 2009 01:58:59 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Joseph Davis updated COUCHDB-185:
--------------------------------------

    Attachment: COUCHDB-185.patch

This patch causes an error for any map-view that has a group=true and/or group_level specified.
Technically if you group_level=0, it won't be caught because that's the default value in the
view parameter record.

Also, this introduces a slight bug into Futon the first time you visit a _design/document
view that contains a reduce function. Before group=true was basically being passed to everything.
I have to get some input from cmlenz on how to detect the _design doc view and if it has a
reduce method. Might require some modification to the view drop down etc.

Also, this throws an error just like all other query_parse_errors, so I think it's technically
a 500 error instead of a 400 as suggested.

Includes test case in the couch_tests.js

> group=true is silently dropped in non-reduce views
> --------------------------------------------------
>
>                 Key: COUCHDB-185
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-185
>             Project: CouchDB
>          Issue Type: Improvement
>    Affects Versions: 0.9
>            Reporter: Maximillian Dornseif
>            Priority: Blocker
>             Fix For: 0.9
>
>         Attachments: COUCHDB-185.patch, group-drop-warning.patch
>
>
> If you query a view without a reduce() function and pass group=true the group parameter
is ignored. This does certainly not follow the principle of least astonishment.
> One might argue, that requesting grouping on something without reduce is generally an
error and thus should result in an HTTP error, but this might break to much existing code.
> But at least the fact, that the parameter was ignored should be logged.
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message