couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Hendricks <mich...@ndrix.org>
Subject Re: svn commit: r689996 - in /incubator/couchdb/branches/json_term_changes: share/www/script/couch_tests.js src/couchdb/couch_httpd.erl
Date Thu, 28 Aug 2008 23:03:27 GMT
On Thu, Aug 28, 2008 at 09:28:06PM -0000, damien@apache.org wrote:
> Author: damien
> Date: Thu Aug 28 14:28:06 2008
> New Revision: 689996
> 
> URL: http://svn.apache.org/viewvc?rev=689996&view=rev
> Log:
> Fix for missing document ID when creating new documents view bulk
> post, and fix the welcome message.

Thanks Damien.  I found another bug on the json_term_changes branch.
When I examine a view and CouchDB tries to spawn a new javascript
instance, I got a 500 error and the following output:

    {"error":"error",
    "reason":"{{badarg,[
        {erlang,binary_to_list,[\"javascript\"]},
        {couch_query_servers,handle_call,3},
        {gen_server,handle_msg,5},
        {proc_lib,init_p,5}]},
        {gen_server,call, [couch_query_servers,{get_port,\"javascript\"}]}}"}

The patch below fixes it.  I'm not sure why the test suite didn't catch
it though.  The only other problem I've found on this branch (creating a
database that already exists) is a regression on trunk too.  I sent a
patch for that on 23 August.

--- couch_query_servers.erl     (revision 690030)
+++ couch_query_servers.erl     (working copy)
@@ -210,7 +210,7 @@
         end,
         {reply, Result, {QueryServerList, LangPorts -- [LangPort]}};
     false ->
-        case lists:keysearch(binary_to_list(Lang), 1, QueryServerList) of
+        case lists:keysearch(Lang, 1, QueryServerList) of
         {value, {_, ServerCmd}} ->
             {reply, {empty, ServerCmd}, {QueryServerList, LangPorts}};
         false -> % not a supported language

-- 
Michael

Mime
View raw message