couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vatam...@apache.org
Subject couchdb-khash git commit: Fix iterator expiry test
Date Mon, 02 Oct 2017 20:41:38 GMT
Repository: couchdb-khash
Updated Branches:
  refs/heads/fix-iterator-test [created] 8048aaf74


Fix iterator expiry test

This test started failing with Erlang 20.0 release. The reason is that opaaque
NIF resources stopped being identifed as empty binaries in Erlang so previously
it matched but once refs were used it stopped matching.

Fixes #855


Project: http://git-wip-us.apache.org/repos/asf/couchdb-khash/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-khash/commit/8048aaf7
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-khash/tree/8048aaf7
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-khash/diff/8048aaf7

Branch: refs/heads/fix-iterator-test
Commit: 8048aaf74994b1f21a6259adcbe69ace3af4bbb3
Parents: 0ca7f7e
Author: Nick Vatamaniuc <vatamane@apache.org>
Authored: Mon Oct 2 16:37:56 2017 -0400
Committer: Nick Vatamaniuc <vatamane@apache.org>
Committed: Mon Oct 2 16:37:56 2017 -0400

----------------------------------------------------------------------
 test/khash_test.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-khash/blob/8048aaf7/test/khash_test.erl
----------------------------------------------------------------------
diff --git a/test/khash_test.erl b/test/khash_test.erl
index 20bd785..f19c858 100644
--- a/test/khash_test.erl
+++ b/test/khash_test.erl
@@ -240,7 +240,7 @@ no_expiration_iterators_test_() ->
                     }
                 end,
                 fun({ok, H, I, Err}) ->
-                    {ok, I} = khash:iter(H),
+                    {ok, _OtherI} = khash:iter(H),
                     {foo, bar} = khash:iter_next(I),
                     end_of_table = khash:iter_next(I),
                     {


Mime
View raw message