couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woh...@apache.org
Subject [couchdb] branch master updated: Disable compaction daemon on eunit run couch startups
Date Sat, 08 Jul 2017 06:19:49 GMT
This is an automated email from the ASF dual-hosted git repository.

wohali pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/couchdb.git


The following commit(s) were added to refs/heads/master by this push:
     new da7aa54  Disable compaction daemon on eunit run couch startups
da7aa54 is described below

commit da7aa54f13e69bef9d2d036155853f2620430d76
Author: Joan Touzet <joant@atypical.net>
AuthorDate: Fri Jul 7 19:59:09 2017 -0400

    Disable compaction daemon on eunit run couch startups
    
    Commit 21f9544 enabled the compaction daemon by default. And commit
    3afe3ad disabled the compaction daemon at the start of the compaction
    daemon tests. Unfortunately, the compaction daemon remains active
    during all the other EUnit tests.
    
    I attempted to override the [compactions] _default line in the file
    rel/files/eunit.ini but specifying `_default=` or `_default=[]` did not
    provide the desired behaviour.
    
    This change disables the _default config as part of
    `test_util:start_couch` after startup. This means there is a very
    brief period during which the daemon is running, but in empirical
    testing the only thing I've seen it manage to do is compact `_dbs`
    before being disabled.
    
    Tested with `make soak-eunit` for 3 hours; this seems to eliminate
    the `all_dbs_active` error we've been seeing in CI runs since the
    compaction daemon was enabled by default.
---
 src/couch/src/test_util.erl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/couch/src/test_util.erl b/src/couch/src/test_util.erl
index 1be177a..54fefd5 100644
--- a/src/couch/src/test_util.erl
+++ b/src/couch/src/test_util.erl
@@ -72,6 +72,7 @@ start_couch(IniFiles, ExtraApps) ->
     load_applications_with_stats(),
     ok = application:set_env(config, ini_files, IniFiles),
     Apps = start_applications(?DEFAULT_APPS ++ ExtraApps),
+    ok = config:delete("compactions", "_default", false),
     #test_context{started = Apps}.
 
 stop_couch() ->

-- 
To stop receiving notification emails like this one, please contact
['"commits@couchdb.apache.org" <commits@couchdb.apache.org>'].

Mime
View raw message