couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woh...@apache.org
Subject [1/2] chttpd commit: updated refs/heads/master to 457bc2d
Date Fri, 02 Sep 2016 10:29:10 GMT
Repository: couchdb-chttpd
Updated Branches:
  refs/heads/master de784a580 -> 457bc2db7


Drop logging level for "no record of user %s"

This warning is tripped primarily when an admin is defined in local.ini
and has no associated _users document. This can happen fairly often in
development and testing setups, meaning that every other line in the
logfile is "no record of user admin".

The right thing to do here might be to check if the currently defined
user is a local admin and only complain in that situation, but presently
chttpd only directly depends on couch_auth_cache and to do so would 
require unencapsulating how couch_auth_cache handles ini file defined
admin users vs. authentication database users, which feels wrong.

Change suggested by @janl in #couchdb-dev IRC.

Project: http://git-wip-us.apache.org/repos/asf/couchdb-chttpd/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-chttpd/commit/e01cc409
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-chttpd/tree/e01cc409
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-chttpd/diff/e01cc409

Branch: refs/heads/master
Commit: e01cc4098c312758025c830214385aa74cedd489
Parents: 35cb938
Author: Joan Touzet <wohali@users.noreply.github.com>
Authored: Thu Sep 1 23:58:37 2016 -0400
Committer: GitHub <noreply@github.com>
Committed: Thu Sep 1 23:58:37 2016 -0400

----------------------------------------------------------------------
 src/chttpd_auth_cache.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-chttpd/blob/e01cc409/src/chttpd_auth_cache.erl
----------------------------------------------------------------------
diff --git a/src/chttpd_auth_cache.erl b/src/chttpd_auth_cache.erl
index 5c06fb7..f3e69de 100644
--- a/src/chttpd_auth_cache.erl
+++ b/src/chttpd_auth_cache.erl
@@ -168,7 +168,7 @@ load_user_from_db(UserName) ->
 	    {Props} = couch_doc:to_json_obj(Doc, []),
 	    Props;
 	_Else ->
-	    couch_log:warning("no record of user ~s", [UserName]),
+	    couch_log:debug("no record of user ~s", [UserName]),
 	    nil
     catch error:database_does_not_exist ->
 	    nil


Mime
View raw message