couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@apache.org
Subject couch-mrview commit: updated refs/heads/master to 157132c
Date Fri, 22 Jul 2016 22:37:07 GMT
Repository: couchdb-couch-mrview
Updated Branches:
  refs/heads/master 3ce28641c -> 157132c6e


Remove outdated test

The module load tests date all the way back to when I first learned
about etap from Nick Gerakines. In the age of meck these are even more
brittle as mocked modules can interfere with the `code:load_file/1`
depending on execution.

Also, given that we were missing almost half of the couch_mrview modules
we obviously don't keep these up to date so they're not serving any
purpose.


Project: http://git-wip-us.apache.org/repos/asf/couchdb-couch-mrview/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-couch-mrview/commit/157132c6
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-couch-mrview/tree/157132c6
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-couch-mrview/diff/157132c6

Branch: refs/heads/master
Commit: 157132c6e603b1870a08c04e8459a177387932ed
Parents: 3ce2864
Author: Paul J. Davis <paul.joseph.davis@gmail.com>
Authored: Fri Jul 22 17:34:03 2016 -0500
Committer: Paul J. Davis <paul.joseph.davis@gmail.com>
Committed: Fri Jul 22 17:36:54 2016 -0500

----------------------------------------------------------------------
 test/couch_mrview_modules_load_tests.erl | 37 ---------------------------
 1 file changed, 37 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-couch-mrview/blob/157132c6/test/couch_mrview_modules_load_tests.erl
----------------------------------------------------------------------
diff --git a/test/couch_mrview_modules_load_tests.erl b/test/couch_mrview_modules_load_tests.erl
deleted file mode 100644
index 15ce443..0000000
--- a/test/couch_mrview_modules_load_tests.erl
+++ /dev/null
@@ -1,37 +0,0 @@
-% Licensed under the Apache License, Version 2.0 (the "License"); you may not
-% use this file except in compliance with the License. You may obtain a copy of
-% the License at
-%
-%   http://www.apache.org/licenses/LICENSE-2.0
-%
-% Unless required by applicable law or agreed to in writing, software
-% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-% License for the specific language governing permissions and limitations under
-% the License.
-
--module(couch_mrview_modules_load_tests).
-
--include_lib("couch/include/couch_eunit.hrl").
-
-
-modules_load_test_() ->
-    {
-        "Verify that all modules loads",
-        should_load_modules()
-    }.
-
-
-should_load_modules() ->
-    Modules = [
-        couch_mrview,
-        couch_mrview_compactor,
-        couch_mrview_http,
-        couch_mrview_index,
-        couch_mrview_updater,
-        couch_mrview_util
-    ],
-    [should_load_module(Mod) || Mod <- Modules].
-
-should_load_module(Mod) ->
-    {atom_to_list(Mod), ?_assertMatch({module, _}, code:load_file(Mod))}.


Mime
View raw message