couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowal...@apache.org
Subject couchdb-nmo git commit: let tests pass in all environments
Date Fri, 05 Feb 2016 00:30:35 GMT
Repository: couchdb-nmo
Updated Branches:
  refs/heads/master 795c3102d -> a3b4c21ef


let tests pass in all environments

the `.invalid` domain name is a special, reserved domain name best
suitable for testing purposes, as it happens that some clients
have something running on some domains or are routed somewhere.

list of reserved domain names:
http://www.iana.org/assignments/special-use-domain-names/special-use-domain-names.xhtml

reference:
http://tools.ietf.org/html/rfc6761

PR: #20
PR-URL: https://github.com/apache/couchdb-nmo/pull/20
Reviewed-By: garren smith <garren.smith@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/couchdb-nmo/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-nmo/commit/a3b4c21e
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-nmo/tree/a3b4c21e
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-nmo/diff/a3b4c21e

Branch: refs/heads/master
Commit: a3b4c21efd96521f4fb2570a1c71eba73972c591
Parents: 795c310
Author: Robert Kowalski <rok@kowalski.gd>
Authored: Thu Jan 14 00:56:20 2016 +0100
Committer: Robert Kowalski <rok@kowalski.gd>
Committed: Fri Feb 5 00:29:47 2016 +0000

----------------------------------------------------------------------
 test/activetasks.js  | 2 +-
 test/couch-config.js | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-nmo/blob/a3b4c21e/test/activetasks.js
----------------------------------------------------------------------
diff --git a/test/activetasks.js b/test/activetasks.js
index 77487ce..1ad1777 100644
--- a/test/activetasks.js
+++ b/test/activetasks.js
@@ -132,7 +132,7 @@ describe('activetasks', () => {
 
     it('returns error for bad connections', () => {
 
-      return getActiveTask('http://127.1.1.10')
+      return getActiveTask('http://doesnotexist.invalid')
       .catch(err => {
         assert.ok(/Could not connect/.test(err.message));
       });

http://git-wip-us.apache.org/repos/asf/couchdb-nmo/blob/a3b4c21e/test/couch-config.js
----------------------------------------------------------------------
diff --git a/test/couch-config.js b/test/couch-config.js
index a57f7cb..dd48e31 100644
--- a/test/couch-config.js
+++ b/test/couch-config.js
@@ -74,9 +74,9 @@ describe('couch-config', () => {
 
     it('getConfig throws error on bad url', () => {
       return getConfig('node1', 'bad-url')
-      .catch(err => {
-        assert.ok(/not a valid url/.test(err.message));
-      });
+        .catch(err => {
+          assert.ok(/not a valid url/.test(err.message));
+        });
     });
 
     it('getConfig throws error on invalid protocol', () => {
@@ -87,7 +87,7 @@ describe('couch-config', () => {
     });
 
     it('gets config bad url returns false', () => {
-      return getConfig('node1', 'http://127.0.0.2/')
+      return getConfig('node1', 'http://badurl.invalid')
         .catch(err => {
           assert.ok(/Could not find node/.test(err.message));
         });


Mime
View raw message