couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowal...@apache.org
Subject [1/3] fauxton commit: updated refs/heads/master to a0886ac
Date Fri, 27 Nov 2015 15:19:22 GMT
Repository: couchdb-fauxton
Updated Branches:
  refs/heads/master eaafe567e -> a0886ac95


remove broken showStale

this was broken in multiple ways (option not visible and if option
visible changing it made no effect)

remove the feature as it has 0 users.

PR: #585
PR-URL: https://github.com/apache/couchdb-fauxton/pull/585
Reviewed-By: Benjamin Keen <ben.keen@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/commit/a0886ac9
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/tree/a0886ac9
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/diff/a0886ac9

Branch: refs/heads/master
Commit: a0886ac95b1a3b2937af984a00abeb078cc8235b
Parents: eeb6756
Author: Robert Kowalski <robertkowalski@apache.org>
Authored: Thu Nov 26 17:53:10 2015 +0100
Committer: Robert Kowalski <robertkowalski@apache.org>
Committed: Fri Nov 27 16:19:08 2015 +0100

----------------------------------------------------------------------
 app/addons/documents/queryoptions/actions.js         |  6 ------
 app/addons/documents/queryoptions/actiontypes.js     |  1 -
 .../documents/queryoptions/queryoptions.react.jsx    | 15 ---------------
 app/addons/documents/queryoptions/stores.js          |  8 --------
 .../tests/queryoptions.componentsSpec.react.jsx      | 14 --------------
 app/addons/documents/shared-routes.js                |  1 -
 6 files changed, 45 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/queryoptions/actions.js
----------------------------------------------------------------------
diff --git a/app/addons/documents/queryoptions/actions.js b/app/addons/documents/queryoptions/actions.js
index 91abd64..642e46a 100644
--- a/app/addons/documents/queryoptions/actions.js
+++ b/app/addons/documents/queryoptions/actions.js
@@ -101,12 +101,6 @@ function (app, FauxtonAPI, ActionTypes, Stores) {
           type: ActionTypes.QUERY_SHOW_REDUCE
         });
       }
-
-      if (options.showStale) {
-        FauxtonAPI.dispatch({
-          type: ActionTypes.QUERY_SHOW_STALE
-        });
-      }
     }
 
   };

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/queryoptions/actiontypes.js
----------------------------------------------------------------------
diff --git a/app/addons/documents/queryoptions/actiontypes.js b/app/addons/documents/queryoptions/actiontypes.js
index b709bc2..aaf4131 100644
--- a/app/addons/documents/queryoptions/actiontypes.js
+++ b/app/addons/documents/queryoptions/actiontypes.js
@@ -23,7 +23,6 @@ define([], function () {
     QUERY_UPDATE_LIMIT: 'QUERY_UPDATE_LIMIT',
     QUERY_RESET: 'QUERY_RESET',
     QUERY_SHOW_REDUCE: 'QUERY_SHOW_REDUCE',
-    QUERY_SHOW_STALE: 'QUERY_SHOW_STALE',
     QUERY_UPDATE_GROUP_LEVEL: 'QUERY_UPDATE_GROUP_LEVEL'
   };
 });

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/queryoptions/queryoptions.react.jsx
----------------------------------------------------------------------
diff --git a/app/addons/documents/queryoptions/queryoptions.react.jsx b/app/addons/documents/queryoptions/queryoptions.react.jsx
index c2ac918..1612b71 100644
--- a/app/addons/documents/queryoptions/queryoptions.react.jsx
+++ b/app/addons/documents/queryoptions/queryoptions.react.jsx
@@ -197,19 +197,6 @@ A key value is the first parameter emitted in a map function. For example
emit("
   });
 
   var AdditionalParams = React.createClass({
-    showStale: function () {
-      if (!this.props.showStale) {
-        return null;
-      }
-
-      return (
-        <div className="checkbox inline">
-          <input id="qoStale" name="stale" type="checkbox" defaultValue="ok" />
-          <label htmlFor="qoStale">Stale</label>
-        </div>
-      );
-    },
-
     updateSkip: function (e) {
       e.preventDefault();
       var val = e.target.value;
@@ -236,7 +223,6 @@ A key value is the first parameter emitted in a map function. For example
emit("
         <div className="query-group" id="query-options-additional-params">
           <div className="add-on additionalParams">Additional Parameters</div>
           <div className="row-fluid fieldsets">
-            {this.showStale()}
             <div className="dropdown inline">
               <label className="drop-down">
                 Limit
@@ -302,7 +288,6 @@ A key value is the first parameter emitted in a map function. For example
emit("
         skip: store.skip(),
         limit: store.limit(),
         showReduce: store.showReduce(),
-        showStale: store.showStale(),
         reduce: store.reduce(),
         groupLevel: store.groupLevel()
       };

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/queryoptions/stores.js
----------------------------------------------------------------------
diff --git a/app/addons/documents/queryoptions/stores.js b/app/addons/documents/queryoptions/stores.js
index 656cc97..48c43b8 100644
--- a/app/addons/documents/queryoptions/stores.js
+++ b/app/addons/documents/queryoptions/stores.js
@@ -42,7 +42,6 @@ function (app, FauxtonAPI, ActionTypes) {
       this._groupLevel = 'exact';
 
       this._showReduce = false;
-      this._showStale = false;
     },
 
     isLoading: function () {
@@ -57,10 +56,6 @@ function (app, FauxtonAPI, ActionTypes) {
       return this._reduce;
     },
 
-    showStale: function () {
-      return this._showStale;
-    },
-
     betweenKeys: function () {
       return this._betweenKeys;
     },
@@ -261,9 +256,6 @@ function (app, FauxtonAPI, ActionTypes) {
         case ActionTypes.QUERY_TOGGLE_REDUCE:
           this._reduce = !this._reduce;
         break;
-        case ActionTypes.QUERY_SHOW_STALE:
-          this._showStale = true;
-        break;
         case ActionTypes.QUERY_UPDATE_GROUP_LEVEL:
           this.updateGroupLevel(action.groupLevel);
         break;

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/queryoptions/tests/queryoptions.componentsSpec.react.jsx
----------------------------------------------------------------------
diff --git a/app/addons/documents/queryoptions/tests/queryoptions.componentsSpec.react.jsx
b/app/addons/documents/queryoptions/tests/queryoptions.componentsSpec.react.jsx
index 4810e97..57ad66c 100644
--- a/app/addons/documents/queryoptions/tests/queryoptions.componentsSpec.react.jsx
+++ b/app/addons/documents/queryoptions/tests/queryoptions.componentsSpec.react.jsx
@@ -160,20 +160,6 @@ define([
         paramsEl.updateSkip({target: {value: '3'}, preventDefault: function () {}});
         assert.equal(val, '3');
       });
-
-      it('does not show stale if showStale false', function () {
-        var paramsEl = TestUtils.renderIntoDocument(<Views.AdditionalParams
-          showStale={false} />, container);
-
-        assert.equal(paramsEl.showStale(), null);
-      });
-
-      it('show stale if showStale true', function () {
-        var paramsEl = TestUtils.renderIntoDocument(<Views.AdditionalParams
-          showStale={true} />, container);
-
-        assert.notEqual(paramsEl.showStale(), null);
-      });
     });
   });
 

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/a0886ac9/app/addons/documents/shared-routes.js
----------------------------------------------------------------------
diff --git a/app/addons/documents/shared-routes.js b/app/addons/documents/shared-routes.js
index 715b3ef..771cc13 100644
--- a/app/addons/documents/shared-routes.js
+++ b/app/addons/documents/shared-routes.js
@@ -80,7 +80,6 @@ define([
         that.rightHeader.showQueryOptions();
         that.rightHeader.resetQueryOptions({
           queryParams: urlParams,
-          showStale: true,
           hasReduce: hasReduceFunction,
           showReduce: !_.isUndefined(hasReduceFunction),
           viewName: viewName,


Mime
View raw message