couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <...@git.apache.org>
Subject [GitHub] couchdb-couch-epi pull request: Simplify couch epi
Date Tue, 29 Sep 2015 16:04:22 GMT
Github user rnewson commented on the pull request:

    https://github.com/apache/couchdb-couch-epi/pull/12#issuecomment-144104309
  
    though it didn't change, could these functions in couch_epi_data_gen.erl be enhanced?;
    from
    ```
    by_key(Handle) ->
        Handle:by_key().
    ```
    
    to 
    ```
    by_key(Handle) when Handle /= undefined ->
        Handle:by_key().
    ```
    
    This might make it easier to catch some errors, the undef is changed to a function_clause.
Is that a clearer error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message