couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davisp <...@git.apache.org>
Subject [GitHub] couchdb-khash pull request: Remove the use of make_hash2
Date Tue, 14 Jul 2015 06:11:38 GMT
GitHub user davisp opened a pull request:

    https://github.com/apache/couchdb-khash/pull/3

    Remove the use of make_hash2

    We were being rather naughty relying on the ability to resolve symbols
    in the executable that loads the NIF. Apparently Windows has a much
    different NIF loading system which prevents this from working. Given
    that the patch for exposing enif_phash was never merged we're solving
    the issue by removing the need from hashing terms in the NIF.
    
    This new approach simply hashes the term in Erlang and passes the
    calculated value in the NIF call. We then just store the calculated
    value along with the key and value as before.
    
    COUCHDB-2750

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-khash 2750-use-phash2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-khash/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit 41047cf58f45b980336c549d15db5fed6a8ee858
Author: Paul J. Davis <paul.joseph.davis@gmail.com>
Date:   2015-07-14T06:08:26Z

    Remove the use of make_hash2
    
    We were being rather naughty relying on the ability to resolve symbols
    in the executable that loads the NIF. Apparently Windows has a much
    different NIF loading system which prevents this from working. Given
    that the patch for exposing enif_phash was never merged we're solving
    the issue by removing the need from hashing terms in the NIF.
    
    This new approach simply hashes the term in Erlang and passes the
    calculated value in the NIF call. We then just store the calculated
    value along with the key and value as before.
    
    COUCHDB-2750

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message