couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowal...@apache.org
Subject [1/2] fauxton commit: updated refs/heads/master to 5752c48
Date Mon, 23 Feb 2015 12:23:54 GMT
Repository: couchdb-fauxton
Updated Branches:
  refs/heads/master c2cb64fbf -> 5752c4862


cleanup: remove useRAF leftovers

Garren and me tried to use the latest layoutmanager in summer
2014 - the experiment lead to performance improvements regarding
the rendering of our application, but we had to disable it as we
as it lead to timing issues.

As we are moving to React it does not make sense to me to invest
further time into the issues we had in summer.

This commit removes the leftovers of the experiment that are not
needed any more and cleans up.

See https://github.com/apache/couchdb-fauxton/pull/29


Project: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/commit/5752c486
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/tree/5752c486
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/diff/5752c486

Branch: refs/heads/master
Commit: 5752c486289ab75e7d6d282bff0c7130e45ab2ec
Parents: be661fb
Author: Robert Kowalski <robertkowalski@apache.org>
Authored: Fri Feb 20 14:14:56 2015 +0100
Committer: Robert Kowalski <robertkowalski@apache.org>
Committed: Mon Feb 23 13:23:15 2015 +0100

----------------------------------------------------------------------
 app/addons/documents/tests/views-changesSpec.js | 6 ++----
 app/addons/fauxton/tests/filterViewSpec.js      | 5 +----
 app/core/base.js                                | 2 --
 3 files changed, 3 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/5752c486/app/addons/documents/tests/views-changesSpec.js
----------------------------------------------------------------------
diff --git a/app/addons/documents/tests/views-changesSpec.js b/app/addons/documents/tests/views-changesSpec.js
index 91c372c..362a0e9 100644
--- a/app/addons/documents/tests/views-changesSpec.js
+++ b/app/addons/documents/tests/views-changesSpec.js
@@ -39,8 +39,7 @@ define([
       handlerSpy = sinon.spy(Views.Changes.prototype, 'toggleJson');
 
       view = new Views.Changes({
-        model: model,
-        useRAF: false
+        model: model
       });
       viewSandbox = new ViewSandbox();
       viewSandbox.renderView(view, done);
@@ -55,8 +54,7 @@ define([
     it('does not keep filters in memory', function () {
       view.filters.push('cat');
       view = new Views.Changes({
-        model: model,
-        useRAF: false
+        model: model
       });
 
       view.filters.push('mat');

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/5752c486/app/addons/fauxton/tests/filterViewSpec.js
----------------------------------------------------------------------
diff --git a/app/addons/fauxton/tests/filterViewSpec.js b/app/addons/fauxton/tests/filterViewSpec.js
index 3a566dc..8ed0548 100644
--- a/app/addons/fauxton/tests/filterViewSpec.js
+++ b/app/addons/fauxton/tests/filterViewSpec.js
@@ -32,8 +32,6 @@ define([
         eventNamespace: 'mynamespace'
       });
 
-      Components.FilterItemView.prototype.useRAF = false;
-
       viewSandbox = new ViewSandbox();
       viewSandbox.renderView(filterView, done);
     });
@@ -74,8 +72,7 @@ define([
     it('should add tooltips when a text for it is defined', function () {
       filterView = new Components.FilterView({
         eventNamespace: 'mynamespace',
-        tooltipText: 'ente ente',
-        useRAF: false
+        tooltipText: 'ente ente'
       });
       viewSandbox.renderView(filterView);
       assert.equal(1, filterView.$('.js-filter-tooltip').length);

http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/5752c486/app/core/base.js
----------------------------------------------------------------------
diff --git a/app/core/base.js b/app/core/base.js
index 61da5e4..73f0a4c 100644
--- a/app/core/base.js
+++ b/app/core/base.js
@@ -62,8 +62,6 @@ function(Backbone, LayoutManager) {
     manage: true,
     disableLoader: false,
 
-    useRAF: false,
-
     forceRender: function () {
       this.hasRendered = false;
     }


Mime
View raw message