couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gar...@apache.org
Subject [15/47] couchdb commit: updated refs/heads/Update-Sidebar-Ui to c173e52
Date Mon, 19 May 2014 16:17:33 GMT
Fix 231-cors.t test suite (again)

That's interesting issue: couch_passwords:hash_admin_password accepts
password as binary string, but list one had been passed instead. This
causes crush with function_clause reason. Ok, but this crush left
hidden for R15/R16 - only R14 shows stack trace in output and alerts
that's something wrong. To be honest, *sometimes* it's also possible
to reproduce this test suite crush with modern Erlang releases,
but it will be about Bad Plan: planned 27 test, but run only 26.
Nothing specific.

So, silent crush prevented other tests to be run and also counted by
the plan. Now this is fixed.


Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/0bb567f4
Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/0bb567f4
Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/0bb567f4

Branch: refs/heads/Update-Sidebar-Ui
Commit: 0bb567f430c12d8686569398b7be91b699d5f9dc
Parents: 079fb84
Author: Alexander Shorin <kxepal@apache.org>
Authored: Tue Apr 29 17:51:15 2014 +0400
Committer: Alexander Shorin <kxepal@apache.org>
Committed: Tue Apr 29 17:51:15 2014 +0400

----------------------------------------------------------------------
 test/etap/231-cors.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb/blob/0bb567f4/test/etap/231-cors.t
----------------------------------------------------------------------
diff --git a/test/etap/231-cors.t b/test/etap/231-cors.t
index c568e79..2f420d1 100644
--- a/test/etap/231-cors.t
+++ b/test/etap/231-cors.t
@@ -32,7 +32,7 @@ server() ->
 main(_) ->
     test_util:init_code_path(),
 
-    etap:plan(26),
+    etap:plan(29),
     case (catch test()) of
         ok ->
             etap:end_tests();
@@ -133,7 +133,7 @@ test() ->
     % test multiple per-host configuration
 
     %% do tests with auth
-    ok = set_admin_password("test", "test"),
+    ok = set_admin_password("test", <<"test">>),
 
     test_db_preflight_auth_request(),
     test_db_origin_auth_request(),


Mime
View raw message