Return-Path: X-Original-To: apmail-couchdb-commits-archive@www.apache.org Delivered-To: apmail-couchdb-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D8DC9D34 for ; Sat, 10 Dec 2011 19:27:26 +0000 (UTC) Received: (qmail 86043 invoked by uid 500); 10 Dec 2011 19:27:25 -0000 Delivered-To: apmail-couchdb-commits-archive@couchdb.apache.org Received: (qmail 85986 invoked by uid 500); 10 Dec 2011 19:27:25 -0000 Mailing-List: contact commits-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list commits@couchdb.apache.org Received: (qmail 85979 invoked by uid 99); 10 Dec 2011 19:27:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 19:27:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.114] (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 19:27:22 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 87FC356651; Sat, 10 Dec 2011 19:27:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: fdmanana@apache.org To: commits@couchdb.apache.org X-Mailer: ASF-Git Admin Mailer Subject: git commit: Remove bad couch_db:close/1 call Message-Id: <20111210192701.87FC356651@tyr.zones.apache.org> Date: Sat, 10 Dec 2011 19:27:01 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Updated Branches: refs/heads/master 1aafbf4b3 -> 8b9495158 Remove bad couch_db:close/1 call This is unnecessary as the changes feed loop will do the necessary database close once it starts waiting for database update events. Plus, this close call will fail when the database is deleted - this causes sporadic replicator_db.js test failures. Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/8b949515 Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/8b949515 Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/8b949515 Branch: refs/heads/master Commit: 8b9495158bc032186d946a4359735562c4d22474 Parents: 1aafbf4 Author: Filipe David Borba Manana Authored: Sat Dec 10 18:44:40 2011 +0000 Committer: Filipe David Borba Manana Committed: Sat Dec 10 19:26:26 2011 +0000 ---------------------------------------------------------------------- .../src/couch_replicator_manager.erl | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/couchdb/blob/8b949515/src/couch_replicator/src/couch_replicator_manager.erl ---------------------------------------------------------------------- diff --git a/src/couch_replicator/src/couch_replicator_manager.erl b/src/couch_replicator/src/couch_replicator_manager.erl index 3d31fa8..087c2c7 100644 --- a/src/couch_replicator/src/couch_replicator_manager.erl +++ b/src/couch_replicator/src/couch_replicator_manager.erl @@ -255,8 +255,7 @@ changes_feed_loop() -> (_, _) -> ok end - ), - couch_db:close(Db) + ) end ), {Pid, RepDbName}.