couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fdman...@apache.org
Subject git commit: Remove bad couch_db:close/1 call
Date Sat, 10 Dec 2011 19:27:19 GMT
Updated Branches:
  refs/heads/1.2.x 53a612793 -> 25754acfd


Remove bad couch_db:close/1 call

This is unnecessary as the changes feed loop will do
the necessary database close once it starts waiting
for database update events. Plus, this close call
will fail when the database is deleted - this causes
sporadic replicator_db.js test failures.


Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/25754acf
Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/25754acf
Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/25754acf

Branch: refs/heads/1.2.x
Commit: 25754acfd36742b2ea17f31c2f9edb64b43e9067
Parents: 53a6127
Author: Filipe David Borba Manana <fdmanana@apache.org>
Authored: Sat Dec 10 18:44:40 2011 +0000
Committer: Filipe David Borba Manana <fdmanana@apache.org>
Committed: Sat Dec 10 18:49:08 2011 +0000

----------------------------------------------------------------------
 src/couchdb/couch_replication_manager.erl |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb/blob/25754acf/src/couchdb/couch_replication_manager.erl
----------------------------------------------------------------------
diff --git a/src/couchdb/couch_replication_manager.erl b/src/couchdb/couch_replication_manager.erl
index 81c6d07..9b58cc4 100644
--- a/src/couchdb/couch_replication_manager.erl
+++ b/src/couchdb/couch_replication_manager.erl
@@ -255,8 +255,7 @@ changes_feed_loop() ->
                 (_, _) ->
                     ok
                 end
-            ),
-            couch_db:close(Db)
+            )
         end
     ),
     {Pid, RepDbName}.


Mime
View raw message